brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
16,171 Commits 180 Branches 237 Tags 70 MiB
e7a90d98ae
Commit Graph

21 Commits

Author SHA1 Message Date
Florian Müllner
40e22eb524 cleanup: Use optional chaining and ?? operator 
Those operators have been supported since gjs switched to mozjs78
last cycle. While not ground-breaking, using it makes for a nice
cleanup here and there.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1517>
 2020-12-02 15:10:29 +00:00
Olivier Fourdan
3541a57570 cleanup: remove controversial naming 
Replace "whitelist" and "blacklist" with "allow" and "deny" in variable
naming, which better represents the purpose of those variables.

There is no functional change.

https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1393
 2020-08-04 13:24:50 +02:00
Jonas Dreßler
73f8c1c482 inhibitShortcutsDialog: Enable line wrapping for additional label 
The inhibitShortcutsDialog can show an additional label which explains
how to restore shortcuts. This label is not managed by the
MessageDialogContent, so we need to enable line wrapping and disable
ellipsization ourselves.

Fixes https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/2616

https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1336
 2020-06-29 10:17:07 +00:00
Jonas Dreßler
d5dbc28f77 inhibitShortcutsDialog: Adapt to new dialog design 
https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/962
 2020-01-27 23:40:04 +01:00
Jonas Dreßler
845c52797b dialog: Rename subtitle property to description 
https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/886
 2020-01-15 00:12:54 +01:00
Jonas Dreßler
5d99bdbe5e dialog: Remove icons from dialogs 
According to the new mockups, remove the icon from MessageDialogContent

See https://gitlab.gnome.org/GNOME/gnome-shell/issues/1343

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/886
 2020-01-15 00:05:34 +01:00
Florian Müllner
ebf77748a8 cleanup: Require "dangling" commas 
Since ES5, trailing commas in arrays and object literals are valid.
We generally haven't used them so far, but they are actually a good
idea, as they make additions and removals in diffs much cleaner.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/805
 2019-11-11 19:25:14 +00:00
Florian Müllner
07cc84f632 cleanup: Only omit braces for single-line blocks 
Braces can be avoided when a block consists of a single statement,
but readability suffers when the statement spans more than a single
line.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/805
 2019-11-11 19:25:14 +00:00
Florian Müllner
682bd7e97c cleanup: Don't shadow variables 
Having variables that share the same name in overlapping scopes is
confusing and error-prone, and is best avoided.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/805
 2019-11-11 19:25:14 +00:00
Florian Müllner
af87bd8c87 cleanup: Use consistent style for ternary operator 
We are currently inconsistent whether to put the operators in front
of the corresponding line or at the end of the preceding one. The
most dominant style for now is to put condition and first branch on
the same line, and then align the second branch:

  let foo = condition ? fooValue
                      : notFooValue;

Unfortunately that's a style that eslint doesn't support, so to account
for it, our legacy configuration currently plainly ignores all indentation
in conditionals.

In order to drop that exception and not let messed up indentation slip
through, change all ternary operators to the non-legacy style.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/725
 2019-09-15 13:30:19 +00:00
Florian Müllner
e357559582 cleanup: Mark globals used from other modules as exported 
eslint cannot figure out that those symbols are used from other modules
via imports, so they trigger unused-variable errors. To fix, explicitly
mark those symbols as exported.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/627
 2019-07-24 00:28:45 +02:00
Florian Müllner
11b116cb9d cleanup: Remove some unhelpful unused variables in destructuring 
We aren't using them, and they don't add much in terms of clarity,
so drop them to fix a couple of eslint errors.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/627
 2019-07-24 00:28:45 +02:00
Florian Müllner
f6b4b96737 cleanup: Use Array.includes() to check for element existence 
We can use that newer method where we don't care about the actual position
of an element inside the array.

(Array.includes() and Array.indexOf() do behave differently in edge cases,
for example in the handling of NaN, but those don't matter to us)

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/152
 2019-07-01 21:28:52 +00:00
Olivier Fourdan
32b8bc39ac inhibitShortcuts: Save choice in permission store 
Use the permission store to remember the user's decision as to whether
or not grant the shortcuts request when the application is known.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/382
 2019-03-04 10:12:58 +01:00
Florian Müllner
fd50b9a45e cleanup: Use destructuring for imports from GI 
This is *much* nicer than repetitive "imports.gi" lines ...

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/399
 2019-02-09 07:39:20 +01:00
Florian Müllner
a1534dab02 cleanup: Clean up unused imports 
Spotted by eslint.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/399
 2019-02-09 05:05:07 +01:00
Florian Müllner
e68dfed1f7 cleanup: Port GObject classes to JS6 classes 
GJS added API for defining GObject classes with ES6 class syntax
last cycle, use it to port the remaining Lang.Class classes to
the new syntax.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/361
 2019-01-25 14:02:44 +00:00
Florian Müllner
76f09b1e49 cleanup: Use method syntax 
Modern javascript has a short-hand for function properties, embrace
it for better readability and to prepare for an eventual port to
ES6 classes.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/23
 2018-02-21 13:54:58 +00:00
Florian Müllner
e8a2c06e4e inhibitShortcuts: Whitelist OS components 
Users already have to trust their OS, so asking whether an OS component
should be allowed to perform an OS operation is odd at best, if not
confusing. Account for this by allowing system components that require a
keyboard grab to work - namely Setting's keyboard shortcuts panel - to
do so without triggering the permissions dialog.

https://bugzilla.gnome.org/show_bug.cgi?id=786146
 2017-08-22 12:09:04 +02:00
Piotr Drąg
090063a1cc ui: fix a translator comment in InhibitShortcutsDialog 
It needs to be exactly one line above the string to be picked up by gettext.
 2017-08-11 19:45:02 +02:00
Florian Müllner
dff3e4e0b9 ui: Add InhibitShortcutsDialog 
https://bugzilla.gnome.org/show_bug.cgi?id=783342
 2017-08-02 11:27:42 +01:00