9 Commits

Author	SHA1	Message	Date
Florian Müllner	e357559582	cleanup: Mark globals used from other modules as exported ... eslint cannot figure out that those symbols are used from other modules via imports, so they trigger unused-variable errors. To fix, explicitly mark those symbols as exported. https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/627	2019-07-24 00:28:45 +02:00
Florian Müllner	6ba03ac2a6	params: Don't use Lang module ... To copy the passed in default parameters, we can just as well use another Object.assign() call. https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/616	2019-07-10 22:09:09 +00:00
Florian Müllner	8a5de327bb	params: Fix regression ... The first parameter to Object.assign() is the same target object that will be returned. That is, since commit 46874eed0 Params.parse() modifies the @defaults object. Usually we pass that parameter as an object literal and this isn't an issue, but the change breaks spectacularly in the few cases where we use a re-usable variable. Restore the previous behavior by copying the object first. https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/615	2019-07-05 18:28:26 +02:00
Florian Müllner	46874eed05	params: Simplify code ... Standard javascript now has Object.assign() which is very similar to Params.parse(), except that the latter by default disallows "extra" parameters. We can still leverage the standard API by simply implementing the error check, and then call out to Object.assign() for the actual parameter merging. https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/612	2019-07-05 11:32:31 +00:00
Florian Müllner	76f09b1e49	cleanup: Use method syntax ... Modern javascript has a short-hand for function properties, embrace it for better readability and to prepare for an eventual port to ES6 classes. https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/23	2018-02-21 13:54:58 +00:00
Dan Winship	75b824d032	*.js: Make emacs modelines consistent ... js2-mode is no longer developed and we recommend js-mode these days, so switch the modelines to specify that, and make them consistent across all files. https://bugzilla.gnome.org/show_bug.cgi?id=660358	2011-10-11 08:05:12 -04:00
Dan Winship	e9e2786fa3	[Params] always return a new object from Params.parse ... Rather than returning a modified copy of the input params/defaults, always return a new object, copying the appropriate values into it. https://bugzilla.gnome.org/show_bug.cgi?id=608667	2010-05-03 12:51:09 -04:00
Dan Winship	8d31c2f4dc	change a few stray tabs to spaces	2010-02-02 10:31:38 -05:00
Dan Winship	e9787c0f1e	Add params.js, for function param object parsing.	2009-11-23 13:48:59 -05:00