Florian Müllner
e357559582
cleanup: Mark globals used from other modules as exported
...
eslint cannot figure out that those symbols are used from other modules
via imports, so they trigger unused-variable errors. To fix, explicitly
mark those symbols as exported.
https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/627
2019-07-24 00:28:45 +02:00
Florian Müllner
11b116cb9d
cleanup: Remove some unhelpful unused variables in destructuring
...
We aren't using them, and they don't add much in terms of clarity,
so drop them to fix a couple of eslint errors.
https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/627
2019-07-24 00:28:45 +02:00
Florian Müllner
f6b4b96737
cleanup: Use Array.includes() to check for element existence
...
We can use that newer method where we don't care about the actual position
of an element inside the array.
(Array.includes() and Array.indexOf() do behave differently in edge cases,
for example in the handling of NaN, but those don't matter to us)
https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/152
2019-07-01 21:28:52 +00:00
Olivier Fourdan
32b8bc39ac
inhibitShortcuts: Save choice in permission store
...
Use the permission store to remember the user's decision as to whether
or not grant the shortcuts request when the application is known.
https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/382
2019-03-04 10:12:58 +01:00
Florian Müllner
fd50b9a45e
cleanup: Use destructuring for imports from GI
...
This is *much* nicer than repetitive "imports.gi" lines ...
https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/399
2019-02-09 07:39:20 +01:00
Florian Müllner
a1534dab02
cleanup: Clean up unused imports
...
Spotted by eslint.
https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/399
2019-02-09 05:05:07 +01:00
Florian Müllner
e68dfed1f7
cleanup: Port GObject classes to JS6 classes
...
GJS added API for defining GObject classes with ES6 class syntax
last cycle, use it to port the remaining Lang.Class classes to
the new syntax.
https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/361
2019-01-25 14:02:44 +00:00
Florian Müllner
76f09b1e49
cleanup: Use method syntax
...
Modern javascript has a short-hand for function properties, embrace
it for better readability and to prepare for an eventual port to
ES6 classes.
https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/23
2018-02-21 13:54:58 +00:00
Florian Müllner
e8a2c06e4e
inhibitShortcuts: Whitelist OS components
...
Users already have to trust their OS, so asking whether an OS component
should be allowed to perform an OS operation is odd at best, if not
confusing. Account for this by allowing system components that require a
keyboard grab to work - namely Setting's keyboard shortcuts panel - to
do so without triggering the permissions dialog.
https://bugzilla.gnome.org/show_bug.cgi?id=786146
2017-08-22 12:09:04 +02:00
Piotr Drąg
090063a1cc
ui: fix a translator comment in InhibitShortcutsDialog
...
It needs to be exactly one line above the string to be picked up by gettext.
2017-08-11 19:45:02 +02:00
Florian Müllner
dff3e4e0b9
ui: Add InhibitShortcutsDialog
...
https://bugzilla.gnome.org/show_bug.cgi?id=783342
2017-08-02 11:27:42 +01:00
