6 Commits

Author	SHA1	Message	Date
Florian Müllner	3b1330880f	cleanup: Use Function.prototype.bind() ... When not using arrow notation with anonymous functions, we use Lang.bind() to bind `this` to named callbacks. However since ES5, this functionality is already provided by Function.prototype.bind() - in fact, Lang.bind() itself uses it when no extra arguments are specified. Just use the built-in function directly where possible, and use arrow notation in the few places where we pass additional arguments. https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/23	2018-02-21 13:55:02 +00:00
Florian Müllner	213e38c2ef	cleanup: Use arrow notation for anonymous functions ... Arrow notation is great, use it consistently through-out the code base to bind `this` to anonymous functions, replacing the more overbose Lang.bind(this, function() {}). https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/23	2018-02-21 13:55:00 +00:00
Florian Müllner	76f09b1e49	cleanup: Use method syntax ... Modern javascript has a short-hand for function properties, embrace it for better readability and to prepare for an eventual port to ES6 classes. https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/23	2018-02-21 13:54:58 +00:00
Florian Müllner	033277b68f	Define externally accessible contants with 'var' instead of 'const' ... Just as we did with classes, define other constants that are (or may be) used from other modules with 'var' to cut down on warnings. https://bugzilla.gnome.org/show_bug.cgi?id=785084	2017-07-18 21:52:06 +02:00
Florian Müllner	2582d16ca7	Define classes with 'var' instead of 'const' ... Any symbols (including class properties) that should be visible outside the module it's defined in need to be defined as global. For now gjs still allows the access for 'const', but get rid of the warnings spill now by changing it. https://bugzilla.gnome.org/show_bug.cgi?id=785084	2017-07-18 21:52:06 +02:00
Florian Müllner	30c7545ff3	audioDeviceSelection: Add audio device selection dialog ... It is not always possible to determine the type of audio device that got plugged in. Add a system modal dialog to query the user in that case and export in on the bus to gnome-settings-daemon. https://bugzilla.gnome.org/show_bug.cgi?id=760284	2016-02-16 17:02:00 +01:00