brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

messageList: Directly take an GioIcon as image for a message

Browse Source 
There is pretty much no value gained by allowing to use any actor to display
an image, so just don't allow it since it simplifies the code and CSS.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3173>
This commit is contained in:
Julian Sparber
2024-02-20 17:03:57 +01:00
committed by Florian Müllner
parent cb1b54b954
commit ffaec5615a
4 changed files with 37 additions and 54 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
js/ui/mpris.js
View File

@@ -1,7 +1,6 @@
import Gio from 'gi://Gio';
import GObject from 'gi://GObject';
import Shell from 'gi://Shell';
import St from 'gi://St';
import * as Signals from '../misc/signals.js';
import * as Main from './main.js';
@@ -24,12 +23,10 @@ export const MediaMessage = GObject.registerClass(
class MediaMessage extends MessageList.Message {
_init(player) {
super._init(player.source, '', '');
this.add_style_class_name('media-message');
this._player = player;
this._icon = new St.Icon({style_class: 'media-message-cover-icon'});
this.setIcon(this._icon);
this._prevButton = this.addMediaControl('media-skip-backward-symbolic',
() => {
this._player.previous();
@@ -65,12 +62,10 @@ class MediaMessage extends MessageList.Message {
this.setBody(this._player.trackArtists.join(', '));
if (this._player.trackCoverUrl) {
let file = Gio.File.new_for_uri(this._player.trackCoverUrl);
this._icon.gicon = new Gio.FileIcon({file});
this._icon.remove_style_class_name('fallback');
const file = Gio.File.new_for_uri(this._player.trackCoverUrl);
this.setIcon(new Gio.FileIcon({file}));
} else {
this._icon.icon_name = 'audio-x-generic-symbolic';
this._icon.add_style_class_name('fallback');
this.setIcon(new Gio.ThemedIcon({name: 'audio-x-generic-symbolic'}));
}
let isPlaying = this._player.status === 'Playing';