From ff7dfa9259fc8f9f84705b6e87318a2cf39f2c80 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Florian=20M=C3=BCllner?= Date: Wed, 4 Dec 2019 19:02:33 +0100 Subject: [PATCH] keyboard: Fix widget leak We currently create an extended-keys popup every time it is requested, but only destroy it (or rather: the last one) when the keyboard itself is destroyed. https://gitlab.gnome.org/GNOME/gnome-shell/issues/1976 --- js/ui/keyboard.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/js/ui/keyboard.js b/js/ui/keyboard.js index a0483cc8a..0d40c8357 100644 --- a/js/ui/keyboard.js +++ b/js/ui/keyboard.js @@ -292,6 +292,9 @@ var Key = GObject.registerClass({ if (this._extendedKeys.length === 0) return; + if (this._boxPointer) + return; + this._boxPointer = new BoxPointer.BoxPointer(St.Side.BOTTOM); this._boxPointer.hide(); Main.layoutManager.addTopChrome(this._boxPointer);