brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cleanup: Also replace Params.parse(..., true) with spread

Browse Source 
This is what Params.parse() boils down to when accepting extra
parameters, so we can just as well use standard syntax here.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3196>
This commit is contained in:
Florian Müllner
2019-12-17 20:06:24 +01:00
parent 8eec7ac3f4
commit fe1eab1b3c
3 changed files with 6 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
js/ui/appDisplay.js
View File

@ -21,7 +21,6 @@ import * as ParentalControlsManager from '../misc/parentalControlsManager.js';
import * as PopupMenu from './popupMenu.js';
import * as Search from './search.js';
import * as SwipeTracker from './swipeTracker.js';
import * as Params from '../misc/params.js';
import * as SystemActions from '../misc/systemActions.js';
import * as Main from './main.js';
@ -2986,10 +2985,9 @@ export const AppIcon = GObject.registerClass({
}, class AppIcon extends AppViewItem {
_init(app, iconParams = {}) {
// Get the isDraggable property without passing it on to the BaseIcon:
const appIconParams = Params.parse(iconParams, {isDraggable: true}, true);
const isDraggable = appIconParams['isDraggable'];
const isDraggable = iconParams['isDraggable'] ?? true;
delete iconParams['isDraggable'];
const expandTitleOnHover = appIconParams['expandTitleOnHover'];
const expandTitleOnHover = iconParams['expandTitleOnHover'];
delete iconParams['expandTitleOnHover'];
super._init({style_class: 'overview-tile'}, isDraggable, expandTitleOnHover);