From fd60591bb3d1b5cf31e7ce735a52ced23d531fa1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Florian=20M=C3=BCllner?= Date: Thu, 28 Oct 2021 19:55:23 +0200 Subject: [PATCH] extensions-tool/prefs: Log D-Bus errors We currently ignore any error that may occur when calling the OpenExtensionPrefs D-Bus method. Right now such an error is highly unlikely, given that we already checked that we are running under gnome-shell and the extension in question exists and has prefs. We'll soon make sure that only one dialog is shown at any time, which is an error that we can realistically expect, so handle that properly. https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/4564 Part-of: (cherry picked from commit 09ed1c533c2350b81e2c79f84998e8d3b4c1199a) --- subprojects/extensions-tool/src/command-prefs.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/subprojects/extensions-tool/src/command-prefs.c b/subprojects/extensions-tool/src/command-prefs.c index 50e4b80ba..01c385e06 100644 --- a/subprojects/extensions-tool/src/command-prefs.c +++ b/subprojects/extensions-tool/src/command-prefs.c @@ -56,6 +56,14 @@ launch_extension_prefs (const char *uuid) NULL, &error); + if (error) + { + g_dbus_error_strip_remote_error (error); + g_printerr (_("Failed to open prefs for extension “%s”: %s\n"), + uuid, error->message); + return FALSE; + } + return TRUE; }