From f8ea825577e43cdd1ae816509de7e69d1cd083e8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Florian=20M=C3=BCllner?= Date: Fri, 22 Mar 2013 19:21:04 +0100 Subject: [PATCH] grabHelper: Consider events that release the grab handled Currently, if a button-press event results in releasing the last modal grab (e.g. clicks outside the grabbed actors), we don't consider the event handled and allow its emission to continue. If we consider dismissing a grab as an action of its own, any additional action triggered by the same event becomes an unexpected side effect. Tweak the capture handler accordingly. https://bugzilla.gnome.org/show_bug.cgi?id=696422 --- js/ui/grabHelper.js | 1 + 1 file changed, 1 insertion(+) diff --git a/js/ui/grabHelper.js b/js/ui/grabHelper.js index 0eed19bd4..9f1374ed7 100644 --- a/js/ui/grabHelper.js +++ b/js/ui/grabHelper.js @@ -355,6 +355,7 @@ const GrabHelper = new Lang.Class({ this._ignoreRelease = true; let i = this._actorInGrabStack(event.get_source()) + 1; this.ungrab({ actor: this._grabStack[i].actor, isUser: true }); + return true; } return this._modalCount > 0;