From f7dc59e3705db1160c8e948944648a637d0def69 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Florian=20M=C3=BCllner?= Date: Fri, 3 Jul 2020 17:28:45 +0200 Subject: [PATCH] shell/window-tracker: Minor simplification Switching to autocleanup gives us a better separation between the app/no-app cases. https://gitlab.gnome.org/GNOME/gnome-shell/issues/219 --- src/shell-window-tracker.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/shell-window-tracker.c b/src/shell-window-tracker.c index 075cb2a16..55637da84 100644 --- a/src/shell-window-tracker.c +++ b/src/shell-window-tracker.c @@ -214,7 +214,7 @@ get_app_from_id (MetaWindow *window, { ShellApp *app; ShellAppSystem *appsys; - char *desktop_file; + g_autofree char *desktop_file = NULL; g_return_val_if_fail (id != NULL, NULL); @@ -223,10 +223,9 @@ get_app_from_id (MetaWindow *window, desktop_file = g_strconcat (id, ".desktop", NULL); app = shell_app_system_lookup_app (appsys, desktop_file); if (app) - g_object_ref (app); + return g_object_ref (app); - g_free (desktop_file); - return app; + return NULL; } /*