From f65826b3ba2cf03a859819e6706046fff376c65c Mon Sep 17 00:00:00 2001 From: Colin Walters Date: Thu, 15 Sep 2011 09:30:38 -0400 Subject: [PATCH] network: Don't notify on connection lost The design is for applications to do this, basically. Web browsers, Evolution, Empathy already display something on network status change. Note though we need an application API in GIO to monitor network state; see https://bugzilla.gnome.org/show_bug.cgi?id=620932 https://bugzilla.gnome.org/show_bug.cgi?id=658954 --- js/ui/status/network.js | 8 -------- 1 file changed, 8 deletions(-) diff --git a/js/ui/status/network.js b/js/ui/status/network.js index 421c5bacc..0dc7ee25e 100644 --- a/js/ui/status/network.js +++ b/js/ui/status/network.js @@ -1742,13 +1742,6 @@ NMApplet.prototype = { if (wrapperClass) { let wrapper = new wrapperClass(this._client, device, this._connections); - wrapper._networkLostId = wrapper.connect('network-lost', Lang.bind(this, function(device) { - this._notifyForDevice(device, 'network-offline', - _("Connectivity lost"), - _("You are no longer connected to the network"), - // set critical urgency to popup the notification automatically - MessageTray.Urgency.CRITICAL); - })); wrapper._activationFailedId = wrapper.connect('activation-failed', Lang.bind(this, function(device, reason) { // XXX: nm-applet has no special text depending on reason // but I'm not sure of this generic message @@ -1761,7 +1754,6 @@ NMApplet.prototype = { this._syncSectionTitle(dev.category); })); wrapper._destroyId = wrapper.connect('destroy', function(wrapper) { - wrapper.disconnect(wrapper._networkLostId); wrapper.disconnect(wrapper._activationFailedId); wrapper.disconnect(wrapper._deviceStateChangedId); wrapper.disconnect(wrapper._destroyId);