brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

loginDialog: Scale focusBin instead of resizing it

Browse Source 
When setting an explicit size as we do currently, rounding errors
(for instance introduced by padding not specified in pixels) may
affect the parent's size allocation, e.g. making it shrink or grow
each time the size is reset.
Rather than taking care of possible rounding errors, set up focusBin
to take up the available width and use scaling for the animation.

https://bugzilla.gnome.org/show_bug.cgi?id=675076
This commit is contained in:
Florian Müllner 2012-07-12 19:49:31 +02:00
parent ec47bd1604
commit f46a165886
1 changed files with 5 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
js/gdm/loginDialog.js
View File

@ -167,8 +167,9 @@ const UserListItem = new Lang.Class({
expand: true }); expand: true });
this._focusBin = new St.Bin({ style_class: 'login-dialog-user-list-item-focus-bin' }); this._focusBin = new St.Bin({ style_class: 'login-dialog-user-list-item-focus-bin' });
this._focusBin.scale_gravity = Clutter.Gravity.CENTER;
this._verticalBox.add(this._focusBin, this._verticalBox.add(this._focusBin,
{ x_fill: false, { x_fill: true,
x_align: St.Align.MIDDLE, x_align: St.Align.MIDDLE,
y_fill: false, y_fill: false,
expand: true }); expand: true });
@ -256,15 +257,10 @@ const UserListItem = new Lang.Class({
showFocusAnimation: function(time) { showFocusAnimation: function(time) {
let hold = new Batch.Hold(); let hold = new Batch.Hold();
let node = this.actor.get_theme_node();
let padding = node.get_horizontal_padding();
let box = this._verticalBox.get_allocation_box();
Tweener.removeTweens(this._focusBin); Tweener.removeTweens(this._focusBin);
this._focusBin.width = 0; this._focusBin.scale_x = 0.;
Tweener.addTween(this._focusBin, Tweener.addTween(this._focusBin,
{ width: (box.x2 - box.x1 - padding), { scale_x: 1.,
time: time, time: time,
transition: 'linear', transition: 'linear',
onComplete: function() { onComplete: function() {
@ -370,7 +366,7 @@ const UserList = new Lang.Class({
let item = this._items[userName]; let item = this._items[userName];
item.actor.can_focus = false; item.actor.can_focus = false;
item._focusBin.width = 0; item._focusBin.scale_x = 0.;
if (item != exception) if (item != exception)
tasks.push(function() { tasks.push(function() {
return _fadeOutActor(item.actor); return _fadeOutActor(item.actor);