brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

slider: Do not notify on parent's behalf

Browse Source 
Instead just use the regular property setter which since commit 3d3dca4aa
already emits the signal and queues a redraw.

https://gitlab.gnome.org/GNOME/gnome-shell/issues/1500
This commit is contained in:
Florian Müllner 2019-08-12 17:40:54 +02:00
parent 6b7af407e1
commit f0e1dc5715
1 changed files with 3 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
js/ui/slider.js
View File

@ -155,10 +155,8 @@ var Slider = GObject.registerClass({
delta = -dy * SLIDER_SCROLL_STEP; delta = -dy * SLIDER_SCROLL_STEP;
} }
this._value = Math.min(Math.max(0, this._value + delta), this._maxValue); this.value = Math.min(Math.max(0, this._value + delta), this._maxValue);
this.queue_repaint();
this.notify('value');
return Clutter.EVENT_STOP; return Clutter.EVENT_STOP;
} }
@ -177,10 +175,8 @@ var Slider = GObject.registerClass({
let key = event.get_key_symbol(); let key = event.get_key_symbol();
if (key == Clutter.KEY_Right || key == Clutter.KEY_Left) { if (key == Clutter.KEY_Right || key == Clutter.KEY_Left) {
let delta = key == Clutter.KEY_Right ? 0.1 : -0.1; let delta = key == Clutter.KEY_Right ? 0.1 : -0.1;
this._value = Math.max(0, Math.min(this._value + delta, this._maxValue));
this.queue_repaint();
this.emit('drag-begin'); this.emit('drag-begin');
this.notify('value'); this.value = Math.max(0, Math.min(this._value + delta, this._maxValue));
this.emit('drag-end'); this.emit('drag-end');
return Clutter.EVENT_STOP; return Clutter.EVENT_STOP;
} }
@ -202,9 +198,7 @@ var Slider = GObject.registerClass({
newvalue = 1; newvalue = 1;
else else
newvalue = (relX - handleRadius) / (width - 2 * handleRadius); newvalue = (relX - handleRadius) / (width - 2 * handleRadius);
this._value = newvalue * this._maxValue; this.value = newvalue * this._maxValue;
this.queue_repaint();
this.notify('value');
} }
_getMinimumIncrement() { _getMinimumIncrement() {