brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

extensions-app: Make error/update icon interactive

Browse Source 
Both icons are not immediately obvious, and the context provided
by the tooltip can be hard to discover.

Address this by making the icons interactive, and provide further
information in a popover.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3051>
This commit is contained in:
Florian Müllner
2023-12-10 23:59:04 +01:00
committed by Marge Bot
parent b2040b20c7
commit ed3394a953
3 changed files with 57 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
subprojects/extensions-app/js/main.js
View File

@ -361,8 +361,8 @@ var ExtensionRow = GObject.registerClass({
'descriptionLabel',
'versionLabel',
'errorLabel',
'errorIcon',
'updatesIcon',
'errorButton',
'updatesButton',
'switch',
'actionsBox',
],
@ -503,13 +503,9 @@ var ExtensionRow = GObject.registerClass({
if (!action.enabled)
this._switch.active = state;
this._updatesIcon.visible = this.hasUpdate;
this._errorIcon.visible = this.hasError;
this._descriptionLabel.visible = !this.hasError;
this._updatesButton.visible = this.hasUpdate;
this._errorButton.visible = this.hasError;
this._errorLabel.label = this.error;
this._errorLabel.visible = this.error !== '';
this._versionLabel.label = this.version.toString();
this._versionLabel.visible = this.version !== '';