brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

MessageTray: destroy notifications manually when the source is destroyed

Browse Source 
Using a signal handlers causes us to depend on connection order, but
we need the message tray code to run last, so it can notice that
notifications are destroyed when hiding the boxpointer and skip
the broken animation.

https://bugzilla.gnome.org/show_bug.cgi?id=686855
This commit is contained in:
Giovanni Campagna 2012-10-25 18:30:27 +02:00
parent a70e74e478
commit ed0e880913
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
js/ui/messageTray.js
View File

@ -404,11 +404,6 @@ const Notification = new Lang.Class({
this._soundFile = null;
this._soundPlayed = false;
source.connect('destroy', Lang.bind(this,
function (source, reason) {
this.destroy(reason);
}));
this.actor = new St.Button({ accessible_role: Atk.Role.NOTIFICATION });
this.actor.add_style_class_name('notification-unexpanded');
this.actor._delegate = this;
@ -1337,6 +1332,13 @@ const Source = new Lang.Class({
destroy: function(reason) {
this.policy.destroy();
let notifications = this.notifications;
this.notifications = [];
for (let i = 0; i < notifications.length; i++)
notifications[i].destroy(reason);
this.emit('destroy', reason);
},