brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cleanup: Require "dangling" commas

Browse Source 
Since ES5, trailing commas in arrays and object literals are valid.
We generally haven't used them so far, but they are actually a good
idea, as they make additions and removals in diffs much cleaner.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/805
This commit is contained in:
Florian Müllner
2019-08-20 23:43:54 +02:00
committed by Georges Basile Stavracas Neto
parent 07cc84f632
commit ebf77748a8
81 changed files with 452 additions and 445 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
js/ui/windowManager.js
View File

@ -124,7 +124,7 @@ class WindowDimmer extends Clutter.BrightnessContrastEffect {
_init() {
super._init({
name: WINDOW_DIMMER_EFFECT_NAME,
enabled: false
enabled: false,
});
this._enabled = true;
}
@ -147,7 +147,7 @@ class WindowDimmer extends Clutter.BrightnessContrastEffect {
this.actor.ease_property(`@effects.${this.name}.brightness`, color, {
mode: Clutter.AnimationMode.LINEAR,
duration: (dimmed ? DIM_TIME : UNDIM_TIME) * (animate ? 1 : 0),
onComplete: () => this._syncEnabled()
onComplete: () => this._syncEnabled(),
});
this._syncEnabled();
@ -432,7 +432,7 @@ class TilePreview extends St.Widget {
height: tileRect.height,
opacity: 255,
duration: WINDOW_ANIMATION_TIME,
mode: Clutter.AnimationMode.EASE_OUT_QUAD
mode: Clutter.AnimationMode.EASE_OUT_QUAD,
});
}
@ -445,7 +445,7 @@ class TilePreview extends St.Widget {
opacity: 0,
duration: WINDOW_ANIMATION_TIME,
mode: Clutter.AnimationMode.EASE_OUT_QUAD,
onComplete: () => this._reset()
onComplete: () => this._reset(),
});
}
@ -1150,7 +1150,7 @@ var WindowManager = class {
y: 0,
duration: WINDOW_ANIMATION_TIME,
mode: Clutter.AnimationMode.EASE_OUT_QUAD,
onComplete: () => this._finishWorkspaceSwitch(switchData)
onComplete: () => this._finishWorkspaceSwitch(switchData),
});
}
@ -1320,7 +1320,7 @@ var WindowManager = class {
this._minimizeWindowDone(shellwm, actor);
else
this._minimizeWindowOverwritten(shellwm, actor);
}
},
});
} else {
let xDest, yDest, xScale, yScale;
@ -1351,7 +1351,7 @@ var WindowManager = class {
y: yDest,
duration: MINIMIZE_WINDOW_ANIMATION_TIME,
mode: Clutter.AnimationMode.EASE_IN_EXPO,
onStopped: () => this._minimizeWindowDone(shellwm, actor)
onStopped: () => this._minimizeWindowDone(shellwm, actor),
});
}
}
@ -1385,7 +1385,7 @@ var WindowManager = class {
opacity: 255,
duration: MINIMIZE_WINDOW_ANIMATION_TIME,
mode: Clutter.AnimationMode.EASE_OUT_QUAD,
onStopped: () => this._unminimizeWindowDone(shellwm, actor)
onStopped: () => this._unminimizeWindowDone(shellwm, actor),
});
} else {
let [success, geom] = actor.meta_window.get_icon_geometry();
@ -1417,7 +1417,7 @@ var WindowManager = class {
y: yDest,
duration: MINIMIZE_WINDOW_ANIMATION_TIME,
mode: Clutter.AnimationMode.EASE_IN_EXPO,
onStopped: () => this._unminimizeWindowDone(shellwm, actor)
onStopped: () => this._unminimizeWindowDone(shellwm, actor),
});
}
}
@ -1493,7 +1493,7 @@ var WindowManager = class {
scale_y: scaleY,
opacity: 0,
duration: WINDOW_ANIMATION_TIME,
mode: Clutter.AnimationMode.EASE_OUT_QUAD
mode: Clutter.AnimationMode.EASE_OUT_QUAD,
});
actor.translation_x = -targetRect.x + sourceRect.x;
@ -1511,7 +1511,7 @@ var WindowManager = class {
translation_y: 0,
duration: WINDOW_ANIMATION_TIME,
mode: Clutter.AnimationMode.EASE_OUT_QUAD,
onStopped: () => this._sizeChangeWindowDone(shellwm, actor)
onStopped: () => this._sizeChangeWindowDone(shellwm, actor),
});
// Now unfreeze actor updates, to get it to the new size.
@ -1641,7 +1641,7 @@ var WindowManager = class {
scale_y: 1,
duration: SHOW_WINDOW_ANIMATION_TIME,
mode: Clutter.AnimationMode.EASE_OUT_EXPO,
onStopped: () => this._mapWindowDone(shellwm, actor)
onStopped: () => this._mapWindowDone(shellwm, actor),
});
break;
case Meta.WindowType.MODAL_DIALOG:
@ -1658,7 +1658,7 @@ var WindowManager = class {
scale_y: 1,
duration: DIALOG_SHOW_WINDOW_ANIMATION_TIME,
mode: Clutter.AnimationMode.EASE_OUT_QUAD,
onStopped: () => this._mapWindowDone(shellwm, actor)
onStopped: () => this._mapWindowDone(shellwm, actor),
});
break;
default:
@ -1712,7 +1712,7 @@ var WindowManager = class {
scale_y: 0.8,
duration: DESTROY_WINDOW_ANIMATION_TIME,
mode: Clutter.AnimationMode.EASE_OUT_QUAD,
onStopped: () => this._destroyWindowDone(shellwm, actor)
onStopped: () => this._destroyWindowDone(shellwm, actor),
});
break;
case Meta.WindowType.MODAL_DIALOG:
@ -1732,7 +1732,7 @@ var WindowManager = class {
scale_y: 0,
duration: DIALOG_DESTROY_WINDOW_ANIMATION_TIME,
mode: Clutter.AnimationMode.EASE_OUT_QUAD,
onStopped: () => this._destroyWindowDone(shellwm, actor)
onStopped: () => this._destroyWindowDone(shellwm, actor),
});
break;
default:
@ -1978,7 +1978,7 @@ var WindowManager = class {
y: yDest,
duration: WINDOW_ANIMATION_TIME,
mode: Clutter.AnimationMode.EASE_OUT_QUAD,
onComplete: () => this._switchWorkspaceDone(shellwm)
onComplete: () => this._switchWorkspaceDone(shellwm),
});
}