From eb8861e9b887b5a15f1b12774e44bbfbf8c82992 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Florian=20M=C3=BCllner?= <fmuellner@gnome.org>
Date: Wed, 15 Nov 2023 14:54:18 +0100
Subject: [PATCH] js: Rely on default scroll policy where appropriate

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3020>
---
 js/gdm/authList.js                  | 1 -
 js/gdm/loginDialog.js               | 2 --
 js/ui/calendar.js                   | 1 -
 js/ui/components/telepathyClient.js | 2 --
 js/ui/dateMenu.js                   | 1 -
 js/ui/dialog.js                     | 1 -
 js/ui/lookingGlass.js               | 2 --
 js/ui/popupMenu.js                  | 1 -
 js/ui/search.js                     | 1 -
 js/ui/unlockDialog.js               | 1 -
 10 files changed, 13 deletions(-)

diff --git a/js/gdm/authList.js b/js/gdm/authList.js
index 7f860a781..2d1254145 100644
--- a/js/gdm/authList.js
+++ b/js/gdm/authList.js
@@ -92,7 +92,6 @@ export const AuthList = GObject.registerClass({
 
         this._scrollView = new St.ScrollView({
             style_class: 'login-dialog-auth-list-view',
-            hscrollbar_policy: St.PolicyType.NEVER,
             child: this._box,
         });
         this.add_child(this._scrollView);
diff --git a/js/gdm/loginDialog.js b/js/gdm/loginDialog.js
index 8644bf3d5..3be7f42ec 100644
--- a/js/gdm/loginDialog.js
+++ b/js/gdm/loginDialog.js
@@ -168,7 +168,6 @@ const UserList = GObject.registerClass({
             style_class: 'login-dialog-user-list-view',
             x_expand: true,
             y_expand: true,
-            hscrollbar_policy: St.PolicyType.NEVER,
         });
 
         this._box = new St.BoxLayout({
@@ -490,7 +489,6 @@ export const LoginDialog = GObject.registerClass({
         this._bannerView = new St.ScrollView({
             style_class: 'login-dialog-banner-view',
             opacity: 0,
-            hscrollbar_policy: St.PolicyType.NEVER,
             child: bannerBox,
         });
         this.add_child(this._bannerView);
diff --git a/js/ui/calendar.js b/js/ui/calendar.js
index ebf8dda55..64663c5af 100644
--- a/js/ui/calendar.js
+++ b/js/ui/calendar.js
@@ -954,7 +954,6 @@ class CalendarMessageList extends St.Widget {
             style_class: 'vfade',
             overlay_scrollbars: true,
             x_expand: true, y_expand: true,
-            hscrollbar_policy: St.PolicyType.NEVER,
         });
         box.add_child(this._scrollView);
 
diff --git a/js/ui/components/telepathyClient.js b/js/ui/components/telepathyClient.js
index 4a66d9151..778c8e7e0 100644
--- a/js/ui/components/telepathyClient.js
+++ b/js/ui/components/telepathyClient.js
@@ -876,8 +876,6 @@ class ChatNotificationBanner extends MessageTray.NotificationBanner {
         });
         this._scrollArea = new St.ScrollView({
             style_class: 'chat-scrollview vfade',
-            vscrollbar_policy: St.PolicyType.AUTOMATIC,
-            hscrollbar_policy: St.PolicyType.NEVER,
             visible: this.expanded,
             child: this._contentArea,
         });
diff --git a/js/ui/dateMenu.js b/js/ui/dateMenu.js
index 0ffd73c76..1d6d22685 100644
--- a/js/ui/dateMenu.js
+++ b/js/ui/dateMenu.js
@@ -929,7 +929,6 @@ class DateMenuButton extends PanelMenu.Button {
             style_class: 'datemenu-displays-section vfade',
             x_expand: true,
             overlay_scrollbars: true,
-            hscrollbar_policy: St.PolicyType.NEVER,
             vscrollbar_policy: St.PolicyType.EXTERNAL,
             child: displaysBox,
         });
diff --git a/js/ui/dialog.js b/js/ui/dialog.js
index f0dc021ce..bb0084203 100644
--- a/js/ui/dialog.js
+++ b/js/ui/dialog.js
@@ -266,7 +266,6 @@ export const ListSection = GObject.registerClass({
 
         this._listScrollView = new St.ScrollView({
             style_class: 'dialog-list-scrollview',
-            hscrollbar_policy: St.PolicyType.NEVER,
             child: this.list,
         });
 
diff --git a/js/ui/lookingGlass.js b/js/ui/lookingGlass.js
index aa422473f..7414a3058 100644
--- a/js/ui/lookingGlass.js
+++ b/js/ui/lookingGlass.js
@@ -164,7 +164,6 @@ const Notebook = GObject.registerClass({
 
         const scrollview = new St.ScrollView({
             child,
-            hscrollbar_policy: St.PolicyType.NEVER,
             y_expand: true,
         });
 
@@ -390,7 +389,6 @@ class ObjInspector extends St.ScrollView {
     _init(lookingGlass) {
         super._init({
             pivot_point: new Graphene.Point({x: 0.5, y: 0.5}),
-            hscrollbar_policy: St.PolicyType.NEVER,
         });
 
         this._obj = null;
diff --git a/js/ui/popupMenu.js b/js/ui/popupMenu.js
index 737188c13..2977d3d61 100644
--- a/js/ui/popupMenu.js
+++ b/js/ui/popupMenu.js
@@ -1014,7 +1014,6 @@ export class PopupSubMenu extends PopupMenuBase {
         // effect if a CSS max-height is set on the top menu.
         this.actor = new St.ScrollView({
             style_class: 'popup-sub-menu',
-            hscrollbar_policy: St.PolicyType.NEVER,
             vscrollbar_policy: St.PolicyType.NEVER,
             child: this.box,
         });
diff --git a/js/ui/search.js b/js/ui/search.js
index 63b034d3c..b90ab33ac 100644
--- a/js/ui/search.js
+++ b/js/ui/search.js
@@ -573,7 +573,6 @@ export const SearchResultsView = GObject.registerClass({
             style_class: 'search-display vfade',
             x_expand: true,
             y_expand: true,
-            hscrollbar_policy: St.PolicyType.NEVER,
             child: this._content,
         });
 
diff --git a/js/ui/unlockDialog.js b/js/ui/unlockDialog.js
index 94da3270d..15ed61a56 100644
--- a/js/ui/unlockDialog.js
+++ b/js/ui/unlockDialog.js
@@ -49,7 +49,6 @@ const NotificationsBox = GObject.registerClass({
         });
 
         this._scrollView = new St.ScrollView({
-            hscrollbar_policy: St.PolicyType.NEVER,
             child: this._notificationBox,
         });
         this.add_child(this._scrollView);