brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

workspaceThumbnail: Destroy thumbnails on destruction

Browse Source 
Often, when using multiple monitors, the thumbnails box may be
destroyed before the 'hidden' signal of the Overview is emitted,
which leaves a bunch of lingering signal connections to the
workspace manager.

Call this._destroyThumbnails() in the _onDestroy handler, which
disconnects from workspace manager. This fixes the some of the log
spam that GNOME Shell produces with backtraces of destroyed actors.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1860>
This commit is contained in:
Georges Basile Stavracas Neto 2021-05-25 12:03:46 -03:00
parent e6089c83e2
commit e9119c625d
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
js/ui/workspaceThumbnail.js
View File

@ -720,6 +720,7 @@ var ThumbnailsBox = GObject.registerClass({
} }
_onDestroy() { _onDestroy() {
this._destroyThumbnails();
this._unqueueUpdateStates(); this._unqueueUpdateStates();
if (this._scrollValueId) if (this._scrollValueId)