brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

search: fix description of results

Browse Source 
"description" is documented as a valid field for search result metas,
and ListSearchResults implements it, so pass it down to be used.
Also, don't wrap the description in quotes, so that the search provider
can decide if it is an excerpt from the searched text or something else.
And to that extent, set use_markup to true, so that terms can be
highlighted.

https://bugzilla.gnome.org/show_bug.cgi?id=694906
This commit is contained in:
Giovanni Campagna 2013-02-27 17:54:09 +01:00
parent 083c37a7b2
commit e7886734c4
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
js/ui/remoteSearch.js
View File

@ -255,6 +255,7 @@ const RemoteSearchProvider = new Lang.Class({
metas[i][prop] = metas[i][prop].deep_unpack(); metas[i][prop] = metas[i][prop].deep_unpack();
resultMetas.push({ id: metas[i]['id'], resultMetas.push({ id: metas[i]['id'],
name: metas[i]['name'], name: metas[i]['name'],
description: metas[i]['description'],
createIcon: Lang.bind(this, createIcon: Lang.bind(this,
this.createIcon, metas[i]) }); this.createIcon, metas[i]) });
} }

5
js/ui/searchDisplay.js
View File

@ -103,10 +103,9 @@ const ListSearchResult = new Lang.Class({
x_align: St.Align.START, x_align: St.Align.START,
y_align: St.Align.START }); y_align: St.Align.START });
// TODO: should highlight terms in the description here
if (this.metaInfo['description']) { if (this.metaInfo['description']) {
let description = new St.Label({ style_class: 'list-search-result-description', let description = new St.Label({ style_class: 'list-search-result-description' });
text: '"' + this.metaInfo['description'] + '"' }); description.clutter_text.set_markup(this.metaInfo['description']);
details.add(description, { x_fill: false, details.add(description, { x_fill: false,
y_fill: false, y_fill: false,
x_align: St.Align.START, x_align: St.Align.START,