From e58fbeea1756d199ed95b33b5a533597746b37a8 Mon Sep 17 00:00:00 2001 From: Cosimo Cecchi Date: Thu, 29 Nov 2012 19:21:41 -0500 Subject: [PATCH] appDisplay: don't increment counter if we didn't add a category Or we'll later try to jump to the wrong category when clicking on it. --- js/ui/appDisplay.js | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/js/ui/appDisplay.js b/js/ui/appDisplay.js index 300c7e75a..851a5118d 100644 --- a/js/ui/appDisplay.js +++ b/js/ui/appDisplay.js @@ -223,7 +223,7 @@ const ViewByCategories = new Lang.Class({ this._loadCategory(dir, apps); if (apps.length == 0) - return; + return false; } let button = new St.Button({ label: GLib.markup_escape_text (name, -1), @@ -244,6 +244,7 @@ const ViewByCategories = new Lang.Class({ } this._categoryBox.add(button, { expand: true, x_fill: true, y_fill: false }); + return true; }, _removeAll: function() { @@ -269,8 +270,9 @@ const ViewByCategories = new Lang.Class({ var dir = iter.get_directory(); if (dir.get_is_nodisplay()) continue; - this._addCategory(dir.get_name(), i, dir); - i++; + + if (this._addCategory(dir.get_name(), i, dir)) + i++; } }