brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

appMenu: Update "new-window" item on state changes

Browse Source 
Stopped apps can *always* open a new window, so before we start
using the menu for non-running apps, make sure to hide the menu
item as necessary.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1948>
This commit is contained in:
Florian Müllner 2021-08-12 03:49:37 +02:00 committed by Marge Bot
parent 321e07c3c6
commit e3c06e3c77
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
js/ui/appMenu.js
View File

@ -93,12 +93,19 @@ var AppMenu = class AppMenu extends PopupMenu.PopupMenu {
return; return;
this._updateQuitItem(); this._updateQuitItem();
this._updateNewWindowItem();
} }
_updateQuitItem() { _updateQuitItem() {
this._quitItem.visible = this._app?.state === Shell.AppState.RUNNING; this._quitItem.visible = this._app?.state === Shell.AppState.RUNNING;
} }
_updateNewWindowItem() {
const actions = this._app?.appInfo?.list_actions() ?? [];
this._newWindowItem.visible =
this._app?.can_open_new_window() && !actions.includes('new-window');
}
_updateDetailsVisibility() { _updateDetailsVisibility() {
const sw = this._appSystem.lookup_app('org.gnome.Software.desktop'); const sw = this._appSystem.lookup_app('org.gnome.Software.desktop');
this._detailsItem.visible = sw !== null; this._detailsItem.visible = sw !== null;
@ -164,9 +171,8 @@ var AppMenu = class AppMenu extends PopupMenu.PopupMenu {
}); });
}); });
this._newWindowItem.visible =
app && app.can_open_new_window() && !actions.includes('new-window');
this._updateQuitItem(); this._updateQuitItem();
this._updateNewWindowItem();
} }
_queueUpdateWindowsSection() { _queueUpdateWindowsSection() {