brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

st/scroll-bar: Remove vertical property

Browse Source 
Unlike `StBoxLayout` which is ubiquious, `StScrollBar` is hightly unlikely
to be used outside of `StScrollView`. It therefore seems unnecessary to
deprecate the `vertical` property before removing it, so do just that.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3614>
This commit is contained in:
Florian Müllner 2025-01-26 20:33:37 +01:00
parent 8b8699d1d5
commit e2de46e9ac
1 changed files with 0 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
src/st/st-scroll-bar.c
View File

@ -79,7 +79,6 @@ enum
PROP_ADJUSTMENT, PROP_ADJUSTMENT,
PROP_ORIENTATION, PROP_ORIENTATION,
PROP_VERTICAL,
N_PROPS N_PROPS
}; };
@ -139,16 +138,6 @@ st_scroll_bar_set_orientation (StScrollBar *bar,
g_object_notify_by_pspec (G_OBJECT (bar), props[PROP_ORIENTATION]); g_object_notify_by_pspec (G_OBJECT (bar), props[PROP_ORIENTATION]);
} }
static void
st_scroll_bar_set_vertical (StScrollBar *bar,
gboolean vertical)
{
st_scroll_bar_set_orientation (bar,
vertical ? CLUTTER_ORIENTATION_VERTICAL
: CLUTTER_ORIENTATION_HORIZONTAL);
g_object_notify_by_pspec (G_OBJECT (bar), props[PROP_VERTICAL]);
}
static void static void
st_scroll_bar_get_property (GObject *gobject, st_scroll_bar_get_property (GObject *gobject,
guint prop_id, guint prop_id,
@ -167,10 +156,6 @@ st_scroll_bar_get_property (GObject *gobject,
g_value_set_enum (value, priv->orientation); g_value_set_enum (value, priv->orientation);
break; break;
case PROP_VERTICAL:
g_value_set_boolean (value, priv->orientation == CLUTTER_ORIENTATION_VERTICAL);
break;
default: default:
G_OBJECT_WARN_INVALID_PROPERTY_ID (gobject, prop_id, pspec); G_OBJECT_WARN_INVALID_PROPERTY_ID (gobject, prop_id, pspec);
break; break;
@ -195,10 +180,6 @@ st_scroll_bar_set_property (GObject *gobject,
st_scroll_bar_set_orientation (bar, g_value_get_enum (value)); st_scroll_bar_set_orientation (bar, g_value_get_enum (value));
break; break;
case PROP_VERTICAL:
st_scroll_bar_set_vertical (bar, g_value_get_boolean (value));
break;
default: default:
G_OBJECT_WARN_INVALID_PROPERTY_ID (gobject, prop_id, pspec); G_OBJECT_WARN_INVALID_PROPERTY_ID (gobject, prop_id, pspec);
break; break;
@ -581,16 +562,6 @@ st_scroll_bar_class_init (StScrollBarClass *klass)
CLUTTER_ORIENTATION_HORIZONTAL, CLUTTER_ORIENTATION_HORIZONTAL,
ST_PARAM_READWRITE | G_PARAM_EXPLICIT_NOTIFY); ST_PARAM_READWRITE | G_PARAM_EXPLICIT_NOTIFY);
/**
* StScrollBar:vertical:
*
* Whether the #StScrollBar is vertical. If %FALSE it is horizontal.
*/
props[PROP_VERTICAL] =
g_param_spec_boolean ("vertical", NULL, NULL,
FALSE,
ST_PARAM_READWRITE | G_PARAM_EXPLICIT_NOTIFY);
g_object_class_install_properties (object_class, N_PROPS, props); g_object_class_install_properties (object_class, N_PROPS, props);