From e2528877318a09ba2dbcd0f6ce995c154d7eab3f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Florian=20M=C3=BCllner?= Date: Mon, 11 Dec 2023 01:41:46 +0100 Subject: [PATCH] extensions-app: Use less concise error strings Now that the error information is displayed in a separate popover, we can afford to be more verbose. Part-of: --- subprojects/extensions-app/js/main.js | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/subprojects/extensions-app/js/main.js b/subprojects/extensions-app/js/main.js index d656e201a..0388eb693 100644 --- a/subprojects/extensions-app/js/main.js +++ b/subprojects/extensions-app/js/main.js @@ -482,11 +482,24 @@ var ExtensionRow = GObject.registerClass({ if (!this.hasError) return ''; - if (this._extension.state === ExtensionState.OUT_OF_DATE) - return _('The extension is incompatible with the current GNOME version'); + if (this._extension.state === ExtensionState.OUT_OF_DATE) { + const {ShellVersion: shellVersion} = this._app.shellProxy; + return this.version !== '' + ? _('The installed version of this extension (%s) is incompatible with the current version of GNOME (%s). The extension has been disabled.').format(this.version, shellVersion) + : _('The installed version of this extension is incompatible with the current version of GNOME (%s). The extension has been disabled.').format(shellVersion); + } - return this._extension.error - ? this._extension.error : _('The extension had an error'); + const message = [ + _('An error has occurred in this extension. This could cause issues elsewhere in the system. It is recommended to turn the extension off until the error is resolved.'), + ]; + + if (this._extension.error) { + message.push( + // translators: Details for an extension error + _('Error details:'), this._extension.error); + } + + return message.join('\n\n'); } get keywords() {