brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

appMenuButton: Rename show/hide to fadeIn/fadeOut

Browse Source 
In the next commit, we will turn PanelMenu.ButtonBox into a
St.Widget subclass. As a domino effect, PanelMenu.Button will
become one too, and so will Panel.AppMenuButton.

When that happens, the current show() and hide() functions in
Panel.AppMenuButton will clash with Clutter.Actor's ones.

To avoid that, rename these functions to fadeIn() and fadeOut()
and avoid a name clash.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/153
This commit is contained in:
Georges Basile Stavracas Neto 2018-08-21 06:48:19 -03:00
parent e9f4f2e8ae
commit dd4709bb27
No known key found for this signature in database
GPG Key ID: 886C17EE170D1385
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
js/ui/panel.js
View File

@ -149,7 +149,7 @@ var AppMenuButton = new Lang.Class({
this._sync(); this._sync();
}, },
show() { fadeIn() {
if (this._visible) if (this._visible)
return; return;
@ -163,7 +163,7 @@ var AppMenuButton = new Lang.Class({
transition: 'easeOutQuad' }); transition: 'easeOutQuad' });
}, },
hide() { fadeOut() {
if (!this._visible) if (!this._visible)
return; return;
@ -314,9 +314,9 @@ var AppMenuButton = new Lang.Class({
shellShowsAppMenu && shellShowsAppMenu &&
!Main.overview.visibleTarget); !Main.overview.visibleTarget);
if (visible) if (visible)
this.show(); this.fadeIn();
else else
this.hide(); this.fadeOut();
let isBusy = (this._targetApp != null && let isBusy = (this._targetApp != null &&
(this._targetApp.get_state() == Shell.AppState.STARTING || (this._targetApp.get_state() == Shell.AppState.STARTING ||