From dd28832dcdb7ef390cc444ec046cfafce56ebc81 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Florian=20M=C3=BCllner?= Date: Wed, 13 Apr 2022 20:14:47 +0200 Subject: [PATCH] background: Pass cancellable when querying file info Otherwise it is possible that the operation completes successfully after the background has been destroyed, which will throw a warning (caused by accessing the this._fileWatches object after it has been nulled). https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/5337 Part-of: --- js/ui/background.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/js/ui/background.js b/js/ui/background.js index 198194a50..825fee0d9 100644 --- a/js/ui/background.js +++ b/js/ui/background.js @@ -492,7 +492,7 @@ var Background = GObject.registerClass({ Gio.FILE_ATTRIBUTE_STANDARD_CONTENT_TYPE, Gio.FileQueryInfoFlags.NONE, 0, - null); + this._cancellable); } catch (e) { this._setLoaded(); return;