From 360338fe07bbb99ade2ef80f7629785a329f1829 Mon Sep 17 00:00:00 2001 From: William Jon McCann Date: Tue, 2 Jun 2009 13:43:34 -0400 Subject: [PATCH 1/3] Shorten overlay animation to 0.25 seconds The animation time for the overlay is a bit long. We're using 0.5 second. From my quick tests of "another system" it takes about half that time to animate. The other system feels about right. http://bugzilla.gnome.org/show_bug.cgi?id=583572 --- js/ui/overlay.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/js/ui/overlay.js b/js/ui/overlay.js index 79eff4f61..83a5c4010 100644 --- a/js/ui/overlay.js +++ b/js/ui/overlay.js @@ -46,7 +46,7 @@ const DETAILS_BORDER_COLOR = new Clutter.Color(); DETAILS_BORDER_COLOR.from_pixel(0xffffffff); // Time for initial animation going into overlay mode -const ANIMATION_TIME = 0.5; +const ANIMATION_TIME = 0.25; // We divide the screen into a grid of rows and columns, which we use // to help us position the overlay components, such as the side panel From 361461d1b9f96f67ea9a2e1810251f6bab02fa38 Mon Sep 17 00:00:00 2001 From: William Jon McCann Date: Wed, 3 Jun 2009 22:24:59 -0400 Subject: [PATCH 2/3] Allow status icons to receive clicks at edge of screen This removes the border and padding and aligns the box to the top. Perhaps we could push the padding down into the active area of the icon since it does look a bit nicer with it. http://bugzilla.gnome.org/show_bug.cgi?id=583139 --- js/ui/panel.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/js/ui/panel.js b/js/ui/panel.js index aa9d4fdd8..a4a9390c9 100644 --- a/js/ui/panel.js +++ b/js/ui/panel.js @@ -12,7 +12,7 @@ const Button = imports.ui.button; const Main = imports.ui.main; const PANEL_HEIGHT = 32; -const TRAY_HEIGHT = 28; +const TRAY_HEIGHT = PANEL_HEIGHT - 1; const SHADOW_HEIGHT = 6; // The panel has a transparent white background with a gradient. @@ -34,7 +34,7 @@ PANEL_BUTTON_COLOR.from_pixel(0x00000015); const PRESSED_BUTTON_BACKGROUND_COLOR = new Clutter.Color(); PRESSED_BUTTON_BACKGROUND_COLOR.from_pixel(0x00000030); -const TRAY_PADDING = 2; +const TRAY_PADDING = 0; const TRAY_SPACING = 2; // Used for the tray icon container with gtk pre-2.16, which doesn't @@ -44,7 +44,7 @@ TRAY_BACKGROUND_COLOR.from_pixel(0xefefefff); const TRAY_BORDER_COLOR = new Clutter.Color(); TRAY_BORDER_COLOR.from_pixel(0x00000033); const TRAY_CORNER_RADIUS = 5; -const TRAY_BORDER_WIDTH = 1; +const TRAY_BORDER_WIDTH = 0; function Panel() { this._init(); @@ -118,7 +118,7 @@ Panel.prototype = { // The tray icons live in trayBox within trayContainer. // The trayBox is hidden when there are no tray icons. let trayContainer = new Big.Box({ orientation: Big.BoxOrientation.VERTICAL, - y_align: Big.BoxAlignment.CENTER }); + y_align: Big.BoxAlignment.START }); box.append(trayContainer, Big.BoxPackFlags.END); let trayBox = new Big.Box({ orientation: Big.BoxOrientation.HORIZONTAL, height: TRAY_HEIGHT, From 015d10b87e2a58ca513b7c5dd1b11515f8456480 Mon Sep 17 00:00:00 2001 From: Colin Walters Date: Thu, 4 Jun 2009 11:03:06 -0400 Subject: [PATCH 3/3] Use title property instead of description for window titles The title property is what we actually want. --- src/shell-app-monitor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/shell-app-monitor.c b/src/shell-app-monitor.c index 2a5f439ef..048e2eab5 100644 --- a/src/shell-app-monitor.c +++ b/src/shell-app-monitor.c @@ -326,7 +326,7 @@ get_active_app_properties (ShellAppMonitor *monitor, return; *wm_class = g_strdup (meta_window_get_wm_class (active)); - *title = g_strdup (meta_window_get_description (active)); + g_object_get (active, "title", title, NULL); } void