From d9ff1f2ec16b7e10276c86d59f08cdf90820ee99 Mon Sep 17 00:00:00 2001 From: Colin Walters Date: Fri, 23 Oct 2009 13:15:13 -0400 Subject: [PATCH] [ShellApp] Ignore removal of windows we're not interested in Previously shell_app_remove_window assumed that it was being passed a window in its list; rather than having callers check whether a window is interesting and only if so removing it from the app, just ignore removal of windows we aren't interested in, like how we ignore addition of windows we already have. https://bugzilla.gnome.org/show_bug.cgi?id=598502 --- src/shell-app.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/shell-app.c b/src/shell-app.c index 3ae3f5c09..a0c56e4f9 100644 --- a/src/shell-app.c +++ b/src/shell-app.c @@ -324,6 +324,9 @@ void _shell_app_remove_window (ShellApp *app, MetaWindow *window) { + if (!g_slist_find (app->windows, window)) + return; + g_signal_handlers_disconnect_by_func (window, G_CALLBACK(shell_app_on_unmanaged), app); g_signal_handlers_disconnect_by_func (window, G_CALLBACK(shell_app_on_user_time_changed), app); g_object_unref (window);