From d57953ad94ef8b58bb37c5d1fc9e6a34f30778ed Mon Sep 17 00:00:00 2001 From: Sebastian Keller Date: Fri, 2 Sep 2022 18:37:13 +0200 Subject: [PATCH] Revert "signalTracker: Use WeakMap in SignalManager to avoid leaking objects" This reverts commit 085102be74f4c98094712a165e5128feaca50438. We need the SignalManager map top be iterable at shutdown for some of the following changes. A WeakMap is not iterable. This revert changes it back to a regular Map, which re-introduces the leaks caused by this. Those will be fixed differently by the two followup commits. Part-of: --- js/misc/signalTracker.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/js/misc/signalTracker.js b/js/misc/signalTracker.js index 8444564df..1c3f4f9df 100644 --- a/js/misc/signalTracker.js +++ b/js/misc/signalTracker.js @@ -42,7 +42,7 @@ class SignalManager { } constructor() { - this._signalTrackers = new WeakMap(); + this._signalTrackers = new Map(); } /**