brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

shell-app: Ignore invalid window PIDs

Browse Source 
When building the list of window PIDs, it's possible Mutter doesn't know
about the PID the client has and meta_window_get_pid() will return 0. We
should handle this case by not adding the PID to the list of PIDs
instead of adding an invalid one to it.

https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1184
This commit is contained in:
Jonas Dreßler 2020-04-06 20:31:46 +02:00 committed by Florian Müllner
parent 4aee87a31b
commit d4db5a59c1
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/shell-app.c
View File

@ -1159,6 +1159,10 @@ shell_app_get_pids (ShellApp *app)
{ {
MetaWindow *window = iter->data; MetaWindow *window = iter->data;
int pid = meta_window_get_pid (window); int pid = meta_window_get_pid (window);
if (pid < 1)
continue;
/* Note in the (by far) common case, app will only have one pid, so /* Note in the (by far) common case, app will only have one pid, so
* we'll hit the first element, so don't worry about O(N^2) here. * we'll hit the first element, so don't worry about O(N^2) here.
*/ */