brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

notifications: Add buttons to Calendar.NotificationMessage via actions

Browse Source 
Since we also want to show the buttons in the calendar move the
code to add buttons/actions from `MessageTray.NotificationBanner` to
`Calendar.NotificationMessage`.

As nothing uses custom buttons that aren't backed by actions anymore,
remove that bit of the public API.

Closes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/7099
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3173>
This commit is contained in:
Julian Sparber
2024-02-21 12:07:10 +01:00
committed by Florian Müllner
parent 7ff5f4ea51
commit d44adf3b78
4 changed files with 71 additions and 87 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
js/ui/messageList.js
View File

@ -469,7 +469,7 @@ export const Message = GObject.registerClass({
});
vbox.add_child(hbox);
this._actionBin = new St.Widget({
this._actionBin = new St.Bin({
layout_manager: new ScaleLayout(),
visible: false,
});
@ -557,17 +557,8 @@ export const Message = GObject.registerClass({
}
setActionArea(actor) {
if (actor == null) {
if (this._actionBin.get_n_children() > 0)
this._actionBin.get_child_at_index(0).destroy();
return;
}
if (this._actionBin.get_n_children() > 0)
throw new Error('Message already has an action area');
this._actionBin.add_child(actor);
this._actionBin.visible = this.expanded;
this._actionBin.child = actor;
this._actionBin.visible = actor && this.expanded;
}
addMediaControl(iconName, callback) {
@ -583,7 +574,7 @@ export const Message = GObject.registerClass({
expand(animate) {
this.expanded = true;
this._actionBin.visible = this._actionBin.get_n_children() > 0;
this._actionBin.visible = !!this._actionBin.child;
const duration = animate ? MessageTray.ANIMATION_TIME : 0;
this._bodyStack.ease_property('@layout.expansion', 1, {