From d15bcd9845e8f43af98e0b7ab14c37a140eab20a Mon Sep 17 00:00:00 2001 From: Ray Strode Date: Tue, 9 Jul 2013 10:05:55 -0400 Subject: [PATCH] loginDialog: don't call nonexistent setInitialKeyFocus function commit ea02380c1524c28e6538ffedb789a12c298742ab changed the login dialog to not use ModalDialog anymore. There's still one lingering setInitialKeyFocus method call in the source, which will cause an exception to be thrown when users have their user list disabled. This commit fixes that. https://bugzilla.gnome.org/show_bug.cgi?id=703874 --- js/gdm/loginDialog.js | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/js/gdm/loginDialog.js b/js/gdm/loginDialog.js index a5f8173e0..dac355ff2 100644 --- a/js/gdm/loginDialog.js +++ b/js/gdm/loginDialog.js @@ -504,6 +504,8 @@ const LoginDialog = new Lang.Class({ y_fill: false, x_align: St.Align.START }); + this._promptEntry.grab_key_focus(); + this._promptMessage = new St.Label({ visible: false }); this._promptBox.add(this._promptMessage, { x_fill: true }); @@ -597,10 +599,6 @@ const LoginDialog = new Lang.Class({ _updateDisableUserList: function() { let disableUserList = this._settings.get_boolean(GdmUtil.DISABLE_USER_LIST_KEY); - // If this is the first time around, set initial focus - if (this._disableUserList == undefined && disableUserList) - this.setInitialKeyFocus(this._promptEntry); - if (disableUserList != this._disableUserList) { this._disableUserList = disableUserList;