brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

st_widget_get_theme_node: g_error if called on an unparented widget

Browse Source 
It's wrong to do anything that requires looking up a widget's style
before you add the widget to the stage, since its final style may
depend on properties inherited from its parents.
st_widget_get_theme_node() used to emit a warning in this case, but
many would-be contributors apparently didn't notice. Help them out.

https://bugzilla.gnome.org/show_bug.cgi?id=610279
This commit is contained in:
Dan Winship 2010-02-17 15:21:51 -05:00
parent b5c2e1c98c
commit d128cc5af3
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/st/st-widget.c
View File

@ -1101,8 +1101,7 @@ st_widget_get_theme_node (StWidget *widget)
if (stage == NULL)
{
g_warning ("st_widget_get_theme_node called on a widget not in a stage");
stage = CLUTTER_STAGE (clutter_stage_get_default ());
g_error ("st_widget_get_theme_node called on a widget not in a stage");
}
if (parent_node == NULL)