From d0dab5a6d1c260963b2b5ba97fcef6f8c7fb03ac Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Florian=20M=C3=BCllner?= Date: Mon, 3 Aug 2020 16:38:17 +0200 Subject: [PATCH] style: Swap text-align in RTL locales https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/3037 --- data/theme/gnome-shell-sass/widgets/_calendar.scss | 4 +++- data/theme/gnome-shell-sass/widgets/_login-dialog.scss | 5 ++--- data/theme/gnome-shell-sass/widgets/_message-list.scss | 4 +++- data/theme/gnome-shell-sass/widgets/_popovers.scss | 4 +++- 4 files changed, 11 insertions(+), 6 deletions(-) diff --git a/data/theme/gnome-shell-sass/widgets/_calendar.scss b/data/theme/gnome-shell-sass/widgets/_calendar.scss index 70d95193a..4f567a82d 100644 --- a/data/theme/gnome-shell-sass/widgets/_calendar.scss +++ b/data/theme/gnome-shell-sass/widgets/_calendar.scss @@ -232,7 +232,9 @@ color: $fg_color; font-feature-settings: "tnum"; @include fontsize($base_font_size); - text-align: right; + + &:ltr { text-align: right; } + &:rtl { text-align: left; } } // timezone offset label diff --git a/data/theme/gnome-shell-sass/widgets/_login-dialog.scss b/data/theme/gnome-shell-sass/widgets/_login-dialog.scss index 0b148bea9..06fdcf25a 100644 --- a/data/theme/gnome-shell-sass/widgets/_login-dialog.scss +++ b/data/theme/gnome-shell-sass/widgets/_login-dialog.scss @@ -138,11 +138,10 @@ .user-widget.horizontal .user-widget-label { @include fontsize($base_font_size + 2); font-weight: bold; - text-align: left; padding-left: 15px; - &:ltr { padding-left: 14px; } - &:rtl { padding-right: 14px; } + &:ltr { padding-left: 14px; text-align: left; } + &:rtl { padding-right: 14px; text-align: right; } } .user-widget.vertical .user-widget-label { diff --git a/data/theme/gnome-shell-sass/widgets/_message-list.scss b/data/theme/gnome-shell-sass/widgets/_message-list.scss index e6a4d92bc..45edb26b2 100644 --- a/data/theme/gnome-shell-sass/widgets/_message-list.scss +++ b/data/theme/gnome-shell-sass/widgets/_message-list.scss @@ -71,9 +71,11 @@ > .event-time { color: transparentize($fg_color, 0.5); @include fontsize($base_font_size - 2); - text-align: right; /* HACK: the label should be baseline-aligned with a 1em label, fake this with some bottom padding */ padding-bottom: 0.13em; + + &:ltr { text-align: right }; + &:rtl { text-align: left }; } } diff --git a/data/theme/gnome-shell-sass/widgets/_popovers.scss b/data/theme/gnome-shell-sass/widgets/_popovers.scss index a693f1503..db9df9aa3 100644 --- a/data/theme/gnome-shell-sass/widgets/_popovers.scss +++ b/data/theme/gnome-shell-sass/widgets/_popovers.scss @@ -76,8 +76,10 @@ $popover_arrow_height: 12px; // container for radio and check boxes .popup-menu-ornament { - text-align: right; width: 1.2em; + + &:ltr { text-align: right }; + &:rtl { text-align: left }; } // separator