brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

theme: Don't give login-dialog another background-color

Browse Source 
Its parent `lockDialogGroup` has exactly the same background-color
set in the same file. Giving them both the same wasted render time on
overdraw, and caused multi-layer blending artifacts (slight flickering
of the grey background) when the login dialog fades in/out.

While the flicker can also be fixed using `set_offscreen_redirect`,
there's no point adding that overhead when the extra layer doesn't need
to be painted. Removing it halves the average render time of the login
animation.

Closes: https://bugs.launchpad.net/bugs/2036388
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3207>
This commit is contained in:
Daniel van Vugt 2024-02-23 15:29:56 +08:00 committed by Marge Bot
parent e46b137b42
commit d09509b2cb
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
data/theme/gnome-shell-sass/widgets/_login-lock.scss
View File

@ -21,8 +21,6 @@ $_gdm_dialog_width: 25em;
// GDM Login Dialog
// uses dark grey system styles
.login-dialog {
background-color: $_gdm_bg;
.login-dialog-prompt-entry {
@extend %system_entry;
}