brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

extensionDownloader: Stop handling 'blacklist' operation

Browse Source 
Blacklist support was added all the way back in commit 1e286e43, but
the code had been defunctional until recently. While uninstalling an
extension that has been blacklisted makes sense off-hand, unfortunately
we don't know if an extension was *actually* blacklisted:

The website returns that operation for any extensions for which it
doesn't find any versions that match the shell version. That is, the
most likely reason is that the user updated to a new GNOME release
which the extension doesn't support yet.

It doesn't look like the website is going to change that behavior any
time soon[0], so drop the 'blacklist' handling for the time being.

[0] https://gitlab.gnome.org/Infrastructure/extensions-web/-/issues/95

https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1132
This commit is contained in:
Florian Müllner 2020-03-26 00:39:29 +01:00 committed by Florian Müllner
parent 26ffeaae47
commit cc347bf6d8
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
js/ui/extensionDownloader.js
View File

@ -156,9 +156,7 @@ function checkForUpdates() {
let operations = JSON.parse(message.response_body.data); let operations = JSON.parse(message.response_body.data);
for (let uuid in operations) { for (let uuid in operations) {
let operation = operations[uuid]; let operation = operations[uuid];
if (operation == 'blacklist') if (operation === 'upgrade' || operation === 'downgrade')
uninstallExtension(uuid);
else if (operation == 'upgrade' || operation == 'downgrade')
downloadExtensionUpdate(uuid); downloadExtensionUpdate(uuid);
} }
}); });