From cbcc5b479a794e2e0980ac4a7aca62bad5cc6ea9 Mon Sep 17 00:00:00 2001 From: Robert Mader Date: Mon, 15 Apr 2024 20:13:40 +0200 Subject: [PATCH] Revert "screencastService: Use 'screen' encoder profile for openH264" Unfortunately it turned out that this change does increase frame skips in the recorded files on several tested devices, greatly outweighing any small visual benefit it might have. This reverts commit 490ecc536ab6b2f9320592930be5aae473297934. Part-of: --- js/dbusServices/screencast/screencastService.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/js/dbusServices/screencast/screencastService.js b/js/dbusServices/screencast/screencastService.js index c96a05dd3..d664a51b0 100644 --- a/js/dbusServices/screencast/screencastService.js +++ b/js/dbusServices/screencast/screencastService.js @@ -38,7 +38,7 @@ const PIPELINES = [ 'capsfilter caps=video/x-raw(memory:DMABuf),max-framerate=%F/1 ! \ glupload ! glcolorconvert ! gldownload ! \ queue ! \ - openh264enc deblocking=off background-detection=false complexity=low adaptive-quantization=false qp-max=26 qp-min=26 multi-thread=%T slice-mode=auto usage-type=screen ! \ + openh264enc deblocking=off background-detection=false complexity=low adaptive-quantization=false qp-max=26 qp-min=26 multi-thread=%T slice-mode=auto ! \ queue ! \ h264parse ! \ mp4mux fragment-duration=500 fragment-mode=first-moov-then-finalise', @@ -50,7 +50,7 @@ const PIPELINES = [ 'capsfilter caps=video/x-raw,max-framerate=%F/1 ! \ videoconvert chroma-mode=none dither=none matrix-mode=output-only n-threads=%T ! \ queue ! \ - openh264enc deblocking=off background-detection=false complexity=low adaptive-quantization=false qp-max=26 qp-min=26 multi-thread=%T slice-mode=auto usage-type=screen ! \ + openh264enc deblocking=off background-detection=false complexity=low adaptive-quantization=false qp-max=26 qp-min=26 multi-thread=%T slice-mode=auto ! \ queue ! \ h264parse ! \ mp4mux fragment-duration=500 fragment-mode=first-moov-then-finalise',