brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

st-theme-node: Improve borders with gradient backgrounds

Browse Source 
For gradient backgrounds, borders were implemented by filling the
background shape with the border color first, and then scaling down
the path to draw the background.

The result is not correct[0], which is especially visible if the border
width is greater than the border radius - so instead of scaling down
the original path, use a separate path for the background.

The result is consistent with the borders we draw for non-gradient
backgrounds, and much closer to the correct standard behavior.

[0] http://www.w3.org/TR/css3-background/#the-border-radius

https://bugzilla.gnome.org/show_bug.cgi?id=607500
This commit is contained in:
Florian Müllner 2010-12-09 10:35:40 +01:00
parent c648a5f117
commit cb2babb1a0
1 changed files with 75 additions and 45 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

68
src/st/st-theme-node-drawing.c
View File

@ -378,7 +378,6 @@ st_theme_node_render_gradient (StThemeNode *node)
cairo_t *cr; cairo_t *cr;
cairo_surface_t *surface; cairo_surface_t *surface;
cairo_pattern_t *pattern; cairo_pattern_t *pattern;
gboolean round_border = FALSE;
ClutterColor border_color; ClutterColor border_color;
int border_width; int border_width;
guint rowstride; guint rowstride;
@ -397,11 +396,7 @@ st_theme_node_render_gradient (StThemeNode *node)
get_arbitrary_border (node, &border_width, &border_color); get_arbitrary_border (node, &border_width, &border_color);
for (i = 0; i < 4; i++) for (i = 0; i < 4; i++)
{
radius[i] = st_theme_node_get_border_radius (node, i); radius[i] = st_theme_node_get_border_radius (node, i);
if (radius[i] > 0)
round_border = TRUE;
}
if (node->background_gradient_type == ST_GRADIENT_VERTICAL) if (node->background_gradient_type == ST_GRADIENT_VERTICAL)
pattern = cairo_pattern_create_linear (0, 0, 0, node->alloc_height); pattern = cairo_pattern_create_linear (0, 0, 0, node->alloc_height);
@ -427,8 +422,7 @@ st_theme_node_render_gradient (StThemeNode *node)
node->background_gradient_end.blue / 255., node->background_gradient_end.blue / 255.,
node->background_gradient_end.alpha / 255.); node->background_gradient_end.alpha / 255.);
if (round_border) /* Create a path for the background's outline first */
{
if (radius[ST_CORNER_TOPLEFT] > 0) if (radius[ST_CORNER_TOPLEFT] > 0)
cairo_arc (cr, cairo_arc (cr,
radius[ST_CORNER_TOPLEFT], radius[ST_CORNER_TOPLEFT],
@ -455,15 +449,15 @@ st_theme_node_render_gradient (StThemeNode *node)
node->alloc_height - radius[ST_CORNER_BOTTOMLEFT], node->alloc_height - radius[ST_CORNER_BOTTOMLEFT],
radius[ST_CORNER_BOTTOMLEFT], M_PI / 2, M_PI); radius[ST_CORNER_BOTTOMLEFT], M_PI / 2, M_PI);
cairo_close_path (cr); cairo_close_path (cr);
}
else
cairo_rectangle (cr, 0, 0, node->alloc_width, node->alloc_height);
/* If we have a border, we fill the outline with the border
* color and create the inline shape for the background gradient;
* otherwise the outline shape is filled with the background
* gradient directly
*/
if (border_width > 0) if (border_width > 0)
{ {
cairo_path_t *path;
path = cairo_copy_path (cr);
cairo_set_source_rgba (cr, cairo_set_source_rgba (cr,
border_color.red / 255., border_color.red / 255.,
border_color.green / 255., border_color.green / 255.,
@ -471,12 +465,48 @@ st_theme_node_render_gradient (StThemeNode *node)
border_color.alpha / 255.); border_color.alpha / 255.);
cairo_fill (cr); cairo_fill (cr);
cairo_translate (cr, border_width, border_width); if (radius[ST_CORNER_TOPLEFT] > border_width)
cairo_scale (cr, cairo_arc (cr,
(gdouble)(node->alloc_width - 2 * border_width) / node->alloc_width, radius[ST_CORNER_TOPLEFT],
(gdouble)(node->alloc_height - 2 * border_width) / node->alloc_height); radius[ST_CORNER_TOPLEFT],
cairo_append_path (cr, path); radius[ST_CORNER_TOPLEFT] - border_width,
cairo_path_destroy (path); M_PI, 3 * M_PI / 2);
else
cairo_move_to (cr, border_width, border_width);
cairo_line_to (cr,
node->alloc_width - MAX(radius[ST_CORNER_TOPRIGHT], border_width),
border_width);
if (radius[ST_CORNER_TOPRIGHT] > border_width)
cairo_arc (cr,
node->alloc_width - radius[ST_CORNER_TOPRIGHT],
radius[ST_CORNER_TOPRIGHT],
radius[ST_CORNER_TOPRIGHT] - border_width,
3 * M_PI / 2, 2 * M_PI);
cairo_line_to (cr,
node->alloc_width - border_width,
node->alloc_height - MAX(radius[ST_CORNER_BOTTOMRIGHT], border_width));
if (radius[ST_CORNER_BOTTOMRIGHT] > border_width)
cairo_arc (cr,
node->alloc_width - radius[ST_CORNER_BOTTOMRIGHT],
node->alloc_height - radius[ST_CORNER_BOTTOMRIGHT],
radius[ST_CORNER_BOTTOMRIGHT] - border_width,
0, M_PI / 2);
cairo_line_to (cr,
MAX(radius[ST_CORNER_BOTTOMLEFT], border_width),
node->alloc_height - border_width);
if (radius[ST_CORNER_BOTTOMLEFT] > border_width)
cairo_arc (cr,
radius[ST_CORNER_BOTTOMLEFT],
node->alloc_height - radius[ST_CORNER_BOTTOMLEFT],
radius[ST_CORNER_BOTTOMLEFT] - border_width,
M_PI / 2, M_PI);
cairo_close_path (cr);
} }
cairo_set_source (cr, pattern); cairo_set_source (cr, pattern);