From c9f3afc38fef7fde3791cdbabae5ac66c2e6c03c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Florian=20M=C3=BCllner?= Date: Thu, 28 Aug 2014 16:22:49 +0200 Subject: [PATCH] workspace: Always remove removed windows Since mutter commit 527c53a2a0582eba, MetaWorkspace::window-removed is emitted *before* MetaWindow:workspace is updated, so the test whether the removed window should still be on the workspace in question will always return true. Assume the test is no longer necessary nowadays to fix this very obvious regression. https://bugzilla.gnome.org/show_bug.cgi?id=735608 --- js/ui/workspace.js | 4 ---- js/ui/workspaceThumbnail.js | 4 ---- 2 files changed, 8 deletions(-) diff --git a/js/ui/workspace.js b/js/ui/workspace.js index ddd043110..66058b93d 100644 --- a/js/ui/workspace.js +++ b/js/ui/workspace.js @@ -1417,10 +1417,6 @@ const Workspace = new Lang.Class({ if (index == -1) return; - // Check if window still should be here - if (win && this._isMyWindow(win)) - return; - let clone = this._windows[index]; this._windows.splice(index, 1); diff --git a/js/ui/workspaceThumbnail.js b/js/ui/workspaceThumbnail.js index c11d13bd1..0455a9dd6 100644 --- a/js/ui/workspaceThumbnail.js +++ b/js/ui/workspaceThumbnail.js @@ -367,10 +367,6 @@ const WorkspaceThumbnail = new Lang.Class({ if (index == -1) return; - // Check if window still should be here - if (win && this._isMyWindow(win) && this._isOverviewWindow(win)) - return; - let clone = this._windows[index]; this._windows.splice(index, 1);