brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mpris: Hide unused elements to leave more space for the title

Browse Source 
The Message class this is derived from unconditionally adds a close
button with 0 opacity that only gets shown on hover for messages that
can actually be closed. The MPRIS MediaMessage however can never be
closed and having a close button can cause the title to be cut short
unexpectedly.

Similarly the secondary text which other notifications use to display
the notification time is always left empty here as well.

https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/3664

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1632>
This commit is contained in:
Sebastian Keller 2021-02-04 02:17:08 +01:00 committed by Marge Bot
parent e641547ddf
commit c61e1e5c2c
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
js/ui/mpris.js
View File

@ -28,6 +28,10 @@ class MediaMessage extends MessageList.Message {
this._icon = new St.Icon({ style_class: 'media-message-cover-icon' }); this._icon = new St.Icon({ style_class: 'media-message-cover-icon' });
this.setIcon(this._icon); this.setIcon(this._icon);
// reclaim space used by unused elements
this._secondaryBin.hide();
this._closeButton.hide();
this._prevButton = this.addMediaControl('media-skip-backward-symbolic', this._prevButton = this.addMediaControl('media-skip-backward-symbolic',
() => { () => {
this._player.previous(); this._player.previous();