brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

theme-node: Rewrite switch statement

Browse Source 
Some compilers warn about unhandled enum values in switch statements,
so don't use one where only two out of 21 possible values make sense.
This commit is contained in:
Florian Müllner
2015-09-23 20:00:23 +02:00
parent 82f84416a9
commit c3a29d6df1
1 changed files with 10 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
src/st/st-theme-node.c
View File

@ -840,26 +840,21 @@ st_theme_node_lookup_time (StThemeNode *node,
if (strcmp (decl->property->stryng->str, property_name) == 0)
{
CRTerm *term = decl->value;
int factor = 1;
if (term->type != TERM_NUMBER)
continue;
switch (term->content.num->type)
{
case NUM_TIME_S:
*value = 1000 * term->content.num->val;
result = TRUE;
break;
case NUM_TIME_MS:
*value = term->content.num->val;
result = TRUE;
break;
default:
;
}
if (term->content.num->type != NUM_TIME_S ||
term->content.num->type != NUM_TIME_MS)
continue;
if (result)
break;
if (term->content.num->type == NUM_TIME_S)
factor = 1000;
*value = factor * term->content.num->val;
result = TRUE;
break;
}
}