brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

appFavorites: Fix nonsense condition

Browse Source 
The "in" operator has a lower precedence than negation, so we are
actually testing whether the favorites map contains "false".

Add parentheses to get the intended behavior.

Spotted by eslint.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/375
This commit is contained in:
Florian Müllner 2019-01-29 22:43:41 +01:00 committed by Florian Müllner
parent 91319e3963
commit c353914dd0
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
js/ui/appFavorites.js
View File

@ -153,7 +153,7 @@ class AppFavorites {
} }
_removeFavorite(appId) { _removeFavorite(appId) {
if (!appId in this._favorites) if (!(appId in this._favorites))
return false; return false;
let ids = this._getIds().filter(id => id != appId); let ids = this._getIds().filter(id => id != appId);