From c23ad83c593880c09efcc733cf1ff6dd9453d187 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jonas=20Dre=C3=9Fler?= Date: Tue, 12 May 2020 12:28:03 +0200 Subject: [PATCH] windowManager: Warn when removing old animationInfo Now that we properly notify mutter about when a size-change animation has ended, it should never happen that a new size-change animation is started without the last one being cancelled (ie. 'kill-window-effects' being emitted). This means there should also never be an old animationInfo attached to a window actor, so warn in case we still find one when starting the animation. https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1251 --- js/ui/windowManager.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/js/ui/windowManager.js b/js/ui/windowManager.js index 97601eee4..1ea5daff7 100644 --- a/js/ui/windowManager.js +++ b/js/ui/windowManager.js @@ -1301,8 +1301,10 @@ var WindowManager = class { actor.freeze(); - if (this._clearAnimationInfo(actor)) + if (this._clearAnimationInfo(actor)) { + log('Old animationInfo removed from actor %s'.format(actor)); this._shellwm.completed_size_change(actor); + } let destroyId = actor.connect('destroy', () => { this._clearAnimationInfo(actor);