From b83c93ad62a73a851a88c8f83b48fdce93ad9f80 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jonas=20Dre=C3=9Fler?= Date: Mon, 3 Aug 2020 21:47:42 +0200 Subject: [PATCH] appDisplay: Return false in acceptDrop when not accepting the drop Fix what is probably a copy-paste error and return false instead of a CONTINUE DragMotionResult which is only meant for dragMotion events, not drop events. This makes sure we don't create a folder when dropping an app over the drag leeways of another icon. https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1389 --- js/ui/appDisplay.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/js/ui/appDisplay.js b/js/ui/appDisplay.js index 861db5d5a..1c25dfe39 100644 --- a/js/ui/appDisplay.js +++ b/js/ui/appDisplay.js @@ -1541,7 +1541,7 @@ class AppViewItem extends St.Button { return false; if (this._withinLeeways(x)) - return DND.DragMotionResult.CONTINUE; + return false; return true; }