brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

FdoNotifications: Don't use a fallback for no icon

Browse Source 
There is no need to have an icon for every notification, don't add a
fallback.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3103>
This commit is contained in:
Julian Sparber 2023-12-06 20:48:43 +01:00 committed by Marge Bot
parent eb9118674d
commit b78cc1c62a
1 changed files with 1 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
js/ui/notificationDaemon.js
View File

@ -61,20 +61,6 @@ class FdoNotificationDaemon {
return null; return null;
} }
_fallbackIconForNotificationData(hints) {
let stockIcon;
switch (hints.urgency) {
case Urgency.LOW:
case Urgency.NORMAL:
stockIcon = 'dialog-information';
break;
case Urgency.CRITICAL:
stockIcon = 'dialog-error';
break;
}
return new Gio.ThemedIcon({name: stockIcon});
}
_iconForNotificationData(icon) { _iconForNotificationData(icon) {
if (icon) { if (icon) {
if (icon.substr(0, 7) === 'file://') if (icon.substr(0, 7) === 'file://')
@ -212,10 +198,7 @@ class FdoNotificationDaemon {
}); });
} }
let gicon = this._imageForNotificationData(hints); const gicon = this._imageForNotificationData(hints);
if (!gicon)
gicon = this._fallbackIconForNotificationData(hints);
const soundFile = 'sound-file' in hints const soundFile = 'sound-file' in hints
? Gio.File.new_for_path(hints['sound-file']) : null; ? Gio.File.new_for_path(hints['sound-file']) : null;