From b73159f4145dcb26d71db7bac25e2bb7d0ec0126 Mon Sep 17 00:00:00 2001 From: Sam Hewitt Date: Wed, 20 Nov 2024 13:33:57 -0330 Subject: [PATCH] keyboard: New and updated symbolic assets - renamed all assets to start with osk- disambiguate them from other keyboard status icons - updated the design of hide, enter and keyboard layout icons to be more rounded - new symbolic assets for emoji and delete actions to move away from using 16x16 - updated keyboard scss to use the scalable icon definition - updated the zwnj asset to align with GNOME icon style - changed all references to icons in layouts Part-of: --- data/gnome-shell-icons.gresource.xml | 16 +- .../status/keyboard-enter-symbolic.svg | 4 - .../status/keyboard-hide-symbolic.svg | 5 - .../status/keyboard-layout-symbolic.svg | 4 - .../status/keyboard-zwnj-symbolic.svg | 5 - ...ymbolic.svg => osk-caps-lock-symbolic.svg} | 2 +- .../scalable/status/osk-delete-symbolic.svg | 4 + .../status/osk-emoji-picker-symbolic.svg | 4 + .../scalable/status/osk-enter-symbolic.svg | 4 + .../scalable/status/osk-hide-symbolic.svg | 6 + .../scalable/status/osk-layout-symbolic.svg | 4 + ...ft-symbolic.svg => osk-shift-symbolic.svg} | 2 +- .../scalable/status/osk-zwnj-symbolic.svg | 4 + data/org.gnome.Shell-symbolic.Source.svg | 436 +++++++----------- data/osk-layouts/am.json | 48 +- data/osk-layouts/ara.json | 30 +- data/osk-layouts/at.json | 48 +- data/osk-layouts/be.json | 48 +- data/osk-layouts/bg.json | 48 +- data/osk-layouts/by.json | 48 +- data/osk-layouts/ca.json | 48 +- data/osk-layouts/ch+fr.json | 48 +- data/osk-layouts/ch.json | 48 +- data/osk-layouts/cz.json | 48 +- data/osk-layouts/de.json | 48 +- data/osk-layouts/digits.json | 6 +- data/osk-layouts/dk.json | 48 +- data/osk-layouts/ee.json | 48 +- data/osk-layouts/email.json | 44 +- data/osk-layouts/epo.json | 48 +- data/osk-layouts/es+cat.json | 48 +- data/osk-layouts/es.json | 48 +- data/osk-layouts/fi.json | 48 +- data/osk-layouts/fr.json | 48 +- data/osk-layouts/ge.json | 48 +- data/osk-layouts/gr.json | 48 +- data/osk-layouts/hr.json | 48 +- data/osk-layouts/hu.json | 48 +- data/osk-layouts/id.json | 48 +- data/osk-layouts/il.json | 30 +- data/osk-layouts/in+bolnagri.json | 30 +- data/osk-layouts/in+mal.json | 48 +- data/osk-layouts/ir.json | 32 +- data/osk-layouts/is.json | 48 +- data/osk-layouts/it.json | 48 +- data/osk-layouts/ke.json | 48 +- data/osk-layouts/kg.json | 48 +- data/osk-layouts/kh.json | 30 +- data/osk-layouts/kr.json | 48 +- data/osk-layouts/la.json | 30 +- data/osk-layouts/latam.json | 48 +- data/osk-layouts/lt.json | 48 +- data/osk-layouts/lv.json | 48 +- data/osk-layouts/mk.json | 48 +- data/osk-layouts/mn.json | 48 +- data/osk-layouts/my.json | 48 +- data/osk-layouts/nl.json | 48 +- data/osk-layouts/no.json | 48 +- data/osk-layouts/number.json | 6 +- data/osk-layouts/ph.json | 48 +- data/osk-layouts/phone.json | 6 +- data/osk-layouts/pl.json | 48 +- data/osk-layouts/pt.json | 48 +- data/osk-layouts/ro.json | 48 +- data/osk-layouts/rs.json | 48 +- data/osk-layouts/ru.json | 48 +- data/osk-layouts/se.json | 48 +- data/osk-layouts/si.json | 48 +- data/osk-layouts/sk.json | 48 +- data/osk-layouts/th.json | 48 +- data/osk-layouts/tr.json | 48 +- data/osk-layouts/ua.json | 48 +- data/osk-layouts/uk.json | 48 +- data/osk-layouts/url.json | 44 +- data/osk-layouts/us-extended.json | 52 +-- data/osk-layouts/us.json | 48 +- data/osk-layouts/vn.json | 48 +- data/osk-layouts/za-extended.json | 52 +-- data/osk-layouts/za.json | 48 +- .../gnome-shell-sass/widgets/_keyboard.scss | 2 +- js/ui/keyboard.js | 8 +- 81 files changed, 1646 insertions(+), 1752 deletions(-) delete mode 100644 data/icons/scalable/status/keyboard-enter-symbolic.svg delete mode 100644 data/icons/scalable/status/keyboard-hide-symbolic.svg delete mode 100644 data/icons/scalable/status/keyboard-layout-symbolic.svg delete mode 100644 data/icons/scalable/status/keyboard-zwnj-symbolic.svg rename data/icons/scalable/status/{keyboard-caps-lock-symbolic.svg => osk-caps-lock-symbolic.svg} (83%) create mode 100644 data/icons/scalable/status/osk-delete-symbolic.svg create mode 100644 data/icons/scalable/status/osk-emoji-picker-symbolic.svg create mode 100644 data/icons/scalable/status/osk-enter-symbolic.svg create mode 100644 data/icons/scalable/status/osk-hide-symbolic.svg create mode 100644 data/icons/scalable/status/osk-layout-symbolic.svg rename data/icons/scalable/status/{keyboard-shift-symbolic.svg => osk-shift-symbolic.svg} (62%) create mode 100644 data/icons/scalable/status/osk-zwnj-symbolic.svg diff --git a/data/gnome-shell-icons.gresource.xml b/data/gnome-shell-icons.gresource.xml index a16e6fa16..f0bf289c9 100644 --- a/data/gnome-shell-icons.gresource.xml +++ b/data/gnome-shell-icons.gresource.xml @@ -42,18 +42,20 @@ scalable/status/keyboard-brightness-high-symbolic.svg scalable/status/keyboard-brightness-medium-symbolic.svg scalable/status/keyboard-brightness-off-symbolic.svg - scalable/status/keyboard-caps-lock-symbolic.svg - scalable/status/keyboard-enter-symbolic.svg - scalable/status/keyboard-hide-symbolic.svg - scalable/status/keyboard-layout-symbolic.svg - scalable/status/keyboard-shift-symbolic.svg - scalable/status/keyboard-zwnj-symbolic.svg scalable/status/message-indicator-symbolic.svg scalable/status/no-notifications-symbolic.svg + scalable/status/osk-caps-lock-symbolic.svg + scalable/status/osk-delete-symbolic.svg + scalable/status/osk-emoji-picker-symbolic.svg + scalable/status/osk-enter-symbolic.svg + scalable/status/osk-hide-symbolic.svg + scalable/status/osk-layout-symbolic.svg + scalable/status/osk-shift-symbolic.svg + scalable/status/osk-zwnj-symbolic.svg scalable/status/screen-privacy-disabled-symbolic.svg scalable/status/screen-privacy-symbolic.svg - scalable/status/switch-on-symbolic.svg scalable/status/switch-off-symbolic.svg + scalable/status/switch-on-symbolic.svg scalable/status/wellbeing-symbolic.svg diff --git a/data/icons/scalable/status/keyboard-enter-symbolic.svg b/data/icons/scalable/status/keyboard-enter-symbolic.svg deleted file mode 100644 index 7fe839b4a..000000000 --- a/data/icons/scalable/status/keyboard-enter-symbolic.svg +++ /dev/null @@ -1,4 +0,0 @@ - - - - diff --git a/data/icons/scalable/status/keyboard-hide-symbolic.svg b/data/icons/scalable/status/keyboard-hide-symbolic.svg deleted file mode 100644 index d18bfab5d..000000000 --- a/data/icons/scalable/status/keyboard-hide-symbolic.svg +++ /dev/null @@ -1,5 +0,0 @@ - - - - - diff --git a/data/icons/scalable/status/keyboard-layout-symbolic.svg b/data/icons/scalable/status/keyboard-layout-symbolic.svg deleted file mode 100644 index c93f9355e..000000000 --- a/data/icons/scalable/status/keyboard-layout-symbolic.svg +++ /dev/null @@ -1,4 +0,0 @@ - - - - diff --git a/data/icons/scalable/status/keyboard-zwnj-symbolic.svg b/data/icons/scalable/status/keyboard-zwnj-symbolic.svg deleted file mode 100644 index 7204f474c..000000000 --- a/data/icons/scalable/status/keyboard-zwnj-symbolic.svg +++ /dev/null @@ -1,5 +0,0 @@ - - - - - diff --git a/data/icons/scalable/status/keyboard-caps-lock-symbolic.svg b/data/icons/scalable/status/osk-caps-lock-symbolic.svg similarity index 83% rename from data/icons/scalable/status/keyboard-caps-lock-symbolic.svg rename to data/icons/scalable/status/osk-caps-lock-symbolic.svg index 9efd39432..b98ef7521 100644 --- a/data/icons/scalable/status/keyboard-caps-lock-symbolic.svg +++ b/data/icons/scalable/status/osk-caps-lock-symbolic.svg @@ -1,4 +1,4 @@ - + diff --git a/data/icons/scalable/status/osk-delete-symbolic.svg b/data/icons/scalable/status/osk-delete-symbolic.svg new file mode 100644 index 000000000..f05dfc9e3 --- /dev/null +++ b/data/icons/scalable/status/osk-delete-symbolic.svg @@ -0,0 +1,4 @@ + + + + diff --git a/data/icons/scalable/status/osk-emoji-picker-symbolic.svg b/data/icons/scalable/status/osk-emoji-picker-symbolic.svg new file mode 100644 index 000000000..fdc8715fc --- /dev/null +++ b/data/icons/scalable/status/osk-emoji-picker-symbolic.svg @@ -0,0 +1,4 @@ + + + + diff --git a/data/icons/scalable/status/osk-enter-symbolic.svg b/data/icons/scalable/status/osk-enter-symbolic.svg new file mode 100644 index 000000000..557b220de --- /dev/null +++ b/data/icons/scalable/status/osk-enter-symbolic.svg @@ -0,0 +1,4 @@ + + + + diff --git a/data/icons/scalable/status/osk-hide-symbolic.svg b/data/icons/scalable/status/osk-hide-symbolic.svg new file mode 100644 index 000000000..e7cc0c48d --- /dev/null +++ b/data/icons/scalable/status/osk-hide-symbolic.svg @@ -0,0 +1,6 @@ + + + + + + diff --git a/data/icons/scalable/status/osk-layout-symbolic.svg b/data/icons/scalable/status/osk-layout-symbolic.svg new file mode 100644 index 000000000..ddcc17e5e --- /dev/null +++ b/data/icons/scalable/status/osk-layout-symbolic.svg @@ -0,0 +1,4 @@ + + + + diff --git a/data/icons/scalable/status/keyboard-shift-symbolic.svg b/data/icons/scalable/status/osk-shift-symbolic.svg similarity index 62% rename from data/icons/scalable/status/keyboard-shift-symbolic.svg rename to data/icons/scalable/status/osk-shift-symbolic.svg index 7255259bd..eb5c3bfc2 100644 --- a/data/icons/scalable/status/keyboard-shift-symbolic.svg +++ b/data/icons/scalable/status/osk-shift-symbolic.svg @@ -1,4 +1,4 @@ - + diff --git a/data/icons/scalable/status/osk-zwnj-symbolic.svg b/data/icons/scalable/status/osk-zwnj-symbolic.svg new file mode 100644 index 000000000..fee0a7338 --- /dev/null +++ b/data/icons/scalable/status/osk-zwnj-symbolic.svg @@ -0,0 +1,4 @@ + + + + diff --git a/data/org.gnome.Shell-symbolic.Source.svg b/data/org.gnome.Shell-symbolic.Source.svg index ece7af062..3a5b69a48 100644 --- a/data/org.gnome.Shell-symbolic.Source.svg +++ b/data/org.gnome.Shell-symbolic.Source.svg @@ -14,152 +14,7 @@ xmlns:sodipodi="http://sodipodi.sourceforge.net/DTD/sodipodi-0.dtd" xmlns="http://www.w3.org/2000/svg" xmlns:svg="http://www.w3.org/2000/svg">message-indicator<title id="title41631">screen-privacy<title id="title41633">screen-privacy-disabledkeyboard-shiftosk-shiftkeyboard-caps-lockosk-caps-lockkeyboard-layoutkeyboard-enterosk-enterkeyboard-hideosk-hideosk-zwnjosk-layoutosk-deleteosk-emoji-pickeractionscarousel-arrow-next<title id="title39373">pointer-secondary-click<title id="title39371">pointer-primary-click<title id="title39369">pointer-drag<title id="title39367">pointer-double-clickscreenshot-ui-area<title id="title22">screenshot-ui-displayshell-display-mirrorshell-display-extend-allshell-display-external-onlyshell-display-built-in-onlyscreenshot-ui-windowshell-focus-windows<title id="title42423">screenshot-ui-show-pointerornament-dot-unchecked<title id="title13">preview-closecarousel-arrow-previous<title id="title8">shell-focus-dashshell-focus-app-grid<title id="title19">shell-focus-searchshell-focus-top-barshell-focus-desktop<title id="title16">shell-focus-dash-rtlshell-focus-top-bar-rtlshell-focus-desktop-rtlornament-check<title id="title21">ornament-dot-checked { @@ -1519,7 +1519,7 @@ export const Keyboard = GObject.registerClass({ this._setActiveLevel(key.level); this._setLatched( key.level === 1 && - key.iconName === 'keyboard-caps-lock-symbolic'); + key.iconName === 'osk-caps-lock-symbolic'); } this._longPressed = false; @@ -1540,7 +1540,7 @@ export const Keyboard = GObject.registerClass({ } if (key.action === 'levelSwitch' && - key.iconName === 'keyboard-shift-symbolic') { + key.iconName === 'osk-shift-symbolic') { layout.shiftKeys.push(button); if (key.level === 'shift') { button.connect('long-press', () => { @@ -1623,7 +1623,7 @@ export const Keyboard = GObject.registerClass({ let key = layout.shiftKeys[i]; key.setLatched(latched); key.iconName = latched - ? 'keyboard-caps-lock-symbolic' : 'keyboard-shift-symbolic'; + ? 'osk-caps-lock-symbolic' : 'osk-shift-symbolic'; } }