brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

dnd: Don't mix callback argument and object field usage

Browse Source 
This will be important for the next commit, since _dragComplete()
changes the value of this._dragActor and we need to keep a valid
reference to it.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/744
This commit is contained in:
Georges Basile Stavracas Neto 2018-11-27 12:21:57 -02:00
parent 5880758709
commit b65b4e3cae
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
js/ui/dnd.js
View File

@ -704,8 +704,8 @@ var _Draggable = class _Draggable {
_onAnimationComplete(dragActor, eventTime) { _onAnimationComplete(dragActor, eventTime) {
if (this._dragOrigParent) { if (this._dragOrigParent) {
Main.uiGroup.remove_child(this._dragActor); Main.uiGroup.remove_child(dragActor);
this._dragOrigParent.add_actor(this._dragActor); this._dragOrigParent.add_actor(dragActor);
dragActor.set_scale(this._dragOrigScale, this._dragOrigScale); dragActor.set_scale(this._dragOrigScale, this._dragOrigScale);
dragActor.set_position(this._dragOrigX, this._dragOrigY); dragActor.set_position(this._dragOrigX, this._dragOrigY);
} else { } else {