From b496a9cf9ff8298b04baa1262eeb0f03f5a9473f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Florian=20M=C3=BCllner?= Date: Fri, 26 Jan 2024 00:30:25 +0100 Subject: [PATCH] doc: Use valid code in snippets Some of the code examples use invalid code like `var` as variable name or declarations in a single-statement context. Fix those. Part-of: --- HACKING.md | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/HACKING.md b/HACKING.md index 337bb94bb..617f33be6 100644 --- a/HACKING.md +++ b/HACKING.md @@ -28,7 +28,7 @@ what to do. else bar = do_thing(b); - if (var === 5) { + if (bar === 5) { for (let i = 0; i < 10; i++) print(i); } else { @@ -103,12 +103,13 @@ under the imports: Always use either `const` or `let` when defining a variable. ```javascript // Iterating over an array - for (let i = 0; i < arr.length; ++i) - let item = arr[i]; + for (let i = 0; i < arr.length; ++i) { + const item = arr[i]; + } // Iterating over an object's properties - for (let prop in someobj) { - ... + for (const prop in someobj) { + const val = someobj[prop]; } ```