brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

systemActions: Filter out empty (folded) terms

Browse Source 
We split the search string into words using whitespace, while
GLib.tokenize_and_fold() splits on any non-alphanumeric characters.

That is, a valid search term like ',' will be tokenized as [], so
the original non-empty terms may get mapped to an empty array.

And as [].every() returns true for any condition[0], we end up
matching *all* system actions in that case. We want the exact
opposite and not return any results, so handle that case explicitly.

[0] https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/every

https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/3169
This commit is contained in:
Florian Müllner 2020-09-12 18:32:57 +02:00 committed by Florian Müllner
parent 59ade00b94
commit b2d6c11ec3
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
js/misc/systemActions.js
View File

@ -269,6 +269,10 @@ const SystemActions = GObject.registerClass({
terms = terms.map( terms = terms.map(
term => GLib.str_tokenize_and_fold(term, null)[0]).flat(2); term => GLib.str_tokenize_and_fold(term, null)[0]).flat(2);
// tokenizing may return an empty array
if (terms.length === 0)
return [];
let results = []; let results = [];
for (let [key, { available, keywords }] of this._actions) { for (let [key, { available, keywords }] of this._actions) {