brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

appDisplay: Don't expand title for search results

Browse Source 
It creates quite a nasty visual inconsistency where the
search results' icon title overflows beneath the next
search section.

https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1477
This commit is contained in:
Georges Basile Stavracas Neto 2020-10-21 17:20:59 -03:00
parent efd1e06fec
commit b244274d48
1 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
js/ui/appDisplay.js
View File

@ -1445,16 +1445,19 @@ var AppSearchProvider = class AppSearchProvider {
} }
createResultObject(resultMeta) { createResultObject(resultMeta) {
if (resultMeta.id.endsWith('.desktop')) if (resultMeta.id.endsWith('.desktop')) {
return new AppIcon(this._appSys.lookup_app(resultMeta['id'])); return new AppIcon(this._appSys.lookup_app(resultMeta['id']), {
else expandTitleOnHover: false,
});
} else {
return new SystemActionIcon(this, resultMeta); return new SystemActionIcon(this, resultMeta);
}
} }
}; };
var AppViewItem = GObject.registerClass( var AppViewItem = GObject.registerClass(
class AppViewItem extends St.Button { class AppViewItem extends St.Button {
_init(params = {}, isDraggable = true) { _init(params = {}, isDraggable = true, expandTitleOnHover = true) {
super._init({ super._init({
pivot_point: new Graphene.Point({ x: 0.5, y: 0.5 }), pivot_point: new Graphene.Point({ x: 0.5, y: 0.5 }),
reactive: true, reactive: true,
@ -1474,7 +1477,8 @@ class AppViewItem extends St.Button {
this._otherIconIsHovering = false; this._otherIconIsHovering = false;
this.connect('notify::hover', this._onHover.bind(this)); if (expandTitleOnHover)
this.connect('notify::hover', this._onHover.bind(this));
this.connect('destroy', this._onDestroy.bind(this)); this.connect('destroy', this._onDestroy.bind(this));
} }
@ -2570,8 +2574,10 @@ var AppIcon = GObject.registerClass({
const appIconParams = Params.parse(iconParams, { isDraggable: true }, true); const appIconParams = Params.parse(iconParams, { isDraggable: true }, true);
const isDraggable = appIconParams['isDraggable']; const isDraggable = appIconParams['isDraggable'];
delete iconParams['isDraggable']; delete iconParams['isDraggable'];
const expandTitleOnHover = appIconParams['expandTitleOnHover'];
delete iconParams['expandTitleOnHover'];
super._init({ style_class: 'app-well-app' }, isDraggable); super._init({ style_class: 'app-well-app' }, isDraggable, expandTitleOnHover);
this.app = app; this.app = app;
this._id = app.get_id(); this._id = app.get_id();