brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

inputMethod: Delete the enabled member since it's not used

Browse Source 
When `ibus restart` runs, InputMethod.enabled is changed to false
and no longer enable ibus but 'enabled' and 'disabled' signals
are not used in the current IBus clients and it's good to delete
the member simply.

https://gitlab.gnome.org/GNOME/gnome-shell/issues/295
This commit is contained in:
Takao Fujiwara 2018-12-11 16:18:59 +09:00 committed by Florian Müllner
parent 62abf3edc7
commit ae48f8bda9
1 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
js/misc/inputMethod.js
View File

@ -13,7 +13,6 @@ var InputMethod = new Lang.Class({
this.parent(); this.parent();
this._hints = 0; this._hints = 0;
this._purpose = 0; this._purpose = 0;
this._enabled = true;
this._currentFocus = null; this._currentFocus = null;
this._preeditStr = ''; this._preeditStr = '';
this._preeditPos = 0; this._preeditPos = 0;
@ -62,8 +61,6 @@ var InputMethod = new Lang.Class({
_setContext(bus, res) { _setContext(bus, res) {
this._context = this._ibus.create_input_context_async_finish(res); this._context = this._ibus.create_input_context_async_finish(res);
this._context.connect('enabled', () => { this._enabled = true });
this._context.connect('disabled', () => { this._enabled = false });
this._context.connect('commit-text', this._onCommitText.bind(this)); this._context.connect('commit-text', this._onCommitText.bind(this));
this._context.connect('delete-surrounding-text', this._onDeleteSurroundingText.bind(this)); this._context.connect('delete-surrounding-text', this._onDeleteSurroundingText.bind(this));
this._context.connect('update-preedit-text', this._onUpdatePreeditText.bind(this)); this._context.connect('update-preedit-text', this._onUpdatePreeditText.bind(this));
@ -78,7 +75,6 @@ var InputMethod = new Lang.Class({
this._context = null; this._context = null;
this._hints = 0; this._hints = 0;
this._purpose = 0; this._purpose = 0;
this._enabled = false;
this._preeditStr = '' this._preeditStr = ''
this._preeditPos = 0; this._preeditPos = 0;
this._preeditVisible = false; this._preeditVisible = false;
@ -236,7 +232,7 @@ var InputMethod = new Lang.Class({
}, },
vfunc_filter_key_event(event) { vfunc_filter_key_event(event) {
if (!this._context || !this._enabled) if (!this._context)
return false; return false;
if (!this._currentSource) if (!this._currentSource)
return false; return false;